Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert automatic WPT change upstreaming from a webhook to a GitHub Action #29206

Closed
mrobinson opened this issue Jan 5, 2023 · 1 comment · Fixed by #29217
Closed

Convert automatic WPT change upstreaming from a webhook to a GitHub Action #29206

mrobinson opened this issue Jan 5, 2023 · 1 comment · Fixed by #29217
Assignees
@mrobinson
Labels
A-infrastructure
Projects
Github Actions migration

Comments

@mrobinson
Copy link
Member

This would allow removing more things from saltfs and take care of #23798 as well. The main downside of this is that the action will likely be a bit slower because it has to constantly do shallow clones of both the servo and WPT repositories. In my preliminary testing this takes less than a minute though.

cc @jdm
@mrobinson mrobinson self-assigned this Jan 5, 2023
@mrobinson
Copy link
Member Author

This functionality is currently at https://github.com/servo/upstream-wpt-sync-webhook.

@mrobinson mrobinson added this to To do in Github Actions migration via automation Jan 5, 2023
mrobinson added a commit to mrobinson/servo that referenced this issue Jan 9, 2023
@mrobinson
Add a script to upstream WPT changes via a GitHub Action
56ff8fe 
This is a modified version of the webhook found at
servo/upstream_wpt_webhook and deployed via SaltStack. It is updated to
use modern Python and to assume that GitHub Actions will fetch the
appropriate source code locally before the script is run.

Fixes servo#29206.
Fixes servo#23798.
mrobinson added a commit to mrobinson/servo that referenced this issue Jan 9, 2023
@mrobinson
Add a script to upstream WPT changes via a GitHub Action
8ea0e66 
This is a modified version of the webhook found at
servo/upstream_wpt_webhook and deployed via SaltStack. It is updated to
use modern Python and to assume that GitHub Actions will fetch the
appropriate source code locally before the script is run.

Fixes servo#29206.
Fixes servo#23798.
@mrobinson mrobinson mentioned this issue Jan 9, 2023
Merged
4 tasks
mrobinson added a commit to mrobinson/servo that referenced this issue Jan 9, 2023
@mrobinson
Add a script to upstream WPT changes via a GitHub Action
d0963f5 
This is a modified version of the webhook found at
servo/upstream_wpt_webhook and deployed via SaltStack. It is updated to
use modern Python and to assume that GitHub Actions will fetch the
appropriate source code locally before the script is run.

Fixes servo#29206.
Fixes servo#23798.
mrobinson added a commit that referenced this issue Jan 11, 2023
@mrobinson
Add a script to upstream WPT changes via a GitHub Action
7e121b5 
This is a modified version of the webhook found at
servo/upstream_wpt_webhook and deployed via SaltStack. It is updated to
use modern Python and to assume that GitHub Actions will fetch the
appropriate source code locally before the script is run.

Fixes #29206.
Fixes #23798.

Signed-off-by: Martin Robinson <mrobinson@igalia.com>
bors-servo added a commit that referenced this issue Jan 17, 2023
@bors-servo
Auto merge of #29217 - mrobinson:upstream-wpt-changes, r=delan
a24dc77 
Add a script to upstream WPT changes via a GitHub Action

This is a modified version of the webhook found at https://github.com/servo/upstream_wpt_webhook and deployed via SaltStack. It is updated to use modern Python and to assume that GitHub Actions will fetch the appropriate source code locally before the script is run.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #29206 and #23798
- [x] There are tests for these changes
Github Actions migration automation moved this from To do to Done Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrobinson mrobinson

Labels
A-infrastructure
Projects
Github Actions migration
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a script to upstream WPT changes via a GitHub Action mrobinson/servo
1 participant
@mrobinson