WPT exporter should maybe commit with --allow-empty #31576
Comments
|
I suspect the exporter should do a diff from the main branch and squash all commits together. This should fix issues where it thinks that a change has been made to WPT tests because someone has done a merge from main into their branch. |
|
@mrego can I work on this issue. What do u think about the approach I stated above. |
|
@MunishMummadi Can you explain what you mean by the commands pasted above? I'm a bit lost as to what you are proposing. |
|
@MunishMummadi I'm not sure how what you have commented above solves this problem. You've already claimed one or two issues and have posted PRs. Maybe it makes sense to finish up your work on those things before taking on more tasks. |
|
Hello @mrobinson . I am really sorry If I have caused my trouble. I am trying to do my best. Right now I am working on ##31571 and I drafted ##31747 . I am genuinely sorry for any trouble and I will try to patch those. Thank you |
It's no trouble. It was just a bit of advice to focus and not take on too many issues. Time is also a limited resource for reviewers and we don't always have the bandwidth to mentor people on everything they want to work on. |
In #31534, d5908c9 couldn't be exported to WPT. It worked when I squashed 26eabf7 and d5908c9 together into f840c5b.
I suspect the reason is that the exporter tries to export the commits one by one. So if one of them isn't modifying WPT, the exported commit will be empty. But
--allow-emptyisn't being used, this might have caused the problem.servo/python/wpt/exporter/step.py
Line 156 in ef3dad3
Or possibly the exporter should just squash all the commits together.
The text was updated successfully, but these errors were encountered: