Fix inheritance.sub.html WPT to work on Servo #31534
Conversation
|
🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#44954) with upstreamable changes. |
There was a problem hiding this comment.
Thanks, but while you are at it you should purge the old entries from the expectation files, like
rm tests/wpt/meta/css/css-backgrounds/inheritance.sub.html.ini
./mach test-wpt -r --log-raw /tmp/servo.log --headless tests/wpt/tests/css/css-backgrounds/inheritance.sub.html
./mach update-wpt /tmp/servo.log
rm tests/wpt/meta-legacy-layout/css/css-backgrounds/inheritance.sub.html.ini
./mach test-wpt --legacy-layout -r --log-raw /tmp/servo.log --headless tests/wpt/tests/css/css-backgrounds/inheritance.sub.html
./mach update-wpt --legacy-layout /tmp/servo.log
(Typically you don't need to remove to update the expectations, but in this case it's for purging the obsolete entries)
| @@ -31,7 +31,7 @@ | |||
| </style> | |||
| <script> | |||
| const transparentColor = 'rgba(0, 0, 0, 0)'; // https://www.w3.org/TR/css-color-3/#transparent | |||
| const mediumWidth = getComputedStyle(document.getElementById('reference')).columnRuleWidth; // e.g. 3px | |||
| const mediumWidth = '3px'; | |||
There was a problem hiding this comment.
Could be good to link to https://www.w3.org/TR/css-backgrounds-3/#valdef-line-width-medium
There was a problem hiding this comment.
@Loirooriol, addressed fixes in updated PR, please have a look, thank you!
|
Oh, and when you post a pull request, you should mark the checkboxes in the template, like (arguably fixing a test could also count as "There are tests for these changes", pick whatever you think makes more sense) |
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#44954). |
|
You added an empty patch, possibly by mistake and you wanted to push another one? |
Yes, working on it, pulled main branch so must have been automatically updated |
|
✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#44954) title and body. |
2 similar comments
|
✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#44954) title and body. |
|
✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#44954) title and body. |
|
🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync. |
|
✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#44954) title and body. |
There was a problem hiding this comment.
Thanks, looks good!
BTW, it's noteworthy that since this is a WPT change, it has been exported to that repo: web-platform-tests/wpt#44954
There you can go to the "Checks" tab to ensure that this isn't breaking on other browsers. Effectively, chrome, firefox and safari were passing 64/64 before the change, and still 64/64 after the change, so everything is good.
Great! I will check it, thank you |
Merge queue setting changed
|
Ah, #31453 landed first, so now there is a conflict in |
Head branch was pushed to by a user without write access
azharcodeit
force-pushed
the
fix/servo-31518
branch
from
1bb7e50
to
8d9e7dd
Compare
|
🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync. |
azharcodeit
force-pushed
the
fix/servo-31518
branch
from
8d9e7dd
to
d5908c9
Compare
|
🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync. |
web-platform-tests/wpt#44954 does not include comment with spec link, so it's really out of sync. |
|
It's strange, because initially the bot could export the changes without problems, and the test hasn't been changed upstream: https://github.com/web-platform-tests/wpt/commits/master/css/css-backgrounds/inheritance.sub.html I will investigate tomorrow. |
Loirooriol
force-pushed
the
fix/servo-31518
branch
from
d5908c9
to
f840c5b
Compare
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#44954). |
|
I squashed the commits together and now it works. I suspect the problem was that d5908c9 has no WPT modification, and servo/python/wpt/exporter/step.py Line 156 in ef3dad3 --allow-empty.
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Looks like the failure here was the typical "hdiutil: create failed - Resource busy" that we see. |
Fix inheritance.sub.html WPT to work on Servo
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors