Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Node.type_id private #3203

Closed
Ms2ger opened this issue Sep 3, 2014 · 2 comments · Fixed by #3210
Closed

Make Node.type_id private #3203

Ms2ger opened this issue Sep 3, 2014 · 2 comments · Fixed by #3210
Labels
A-content/dom Interacting with the DOM from web content E-less-complex Straightforward. Recommended for a new contributor. I-safety Some piece of code violates memory safety guarantees.

Comments

@Ms2ger
Copy link
Contributor

Ms2ger commented Sep 3, 2014

No description provided.

@seanmonstar
Copy link
Contributor

I assume the field, not the method?

@jdm
Copy link
Member

jdm commented Sep 4, 2014

Correct.

@seanmonstar seanmonstar mentioned this issue Sep 4, 2014
Merged
@jdm jdm closed this as completed in #3210 Sep 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom Interacting with the DOM from web content E-less-complex Straightforward. Recommended for a new contributor. I-safety Some piece of code violates memory safety guarantees.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make Node.type_id field private, access through type_id() seanmonstar/servo
4 participants
@jdm @seanmonstar @Ms2ger @Manishearth