Allow to specify port with --devtools option (fixes #3597) #3612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Critic review: https://critic.hoppipolla.co.uk/r/2805 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
Thanks; I've left some comments on the critic review! |
|
Now that the Critic review is approved, please squash these commits together and I'll merge them :) |
Note that using `servo --devtools http://example.org` doesn't work. In that case either the port must be specified or the option moved to the end. This is done by getopts and is the same for other such options, e.g. `--profile`.
robinst
force-pushed
the
devtools-port-option
branch
from
1ee64db
to
8a5c6a0
Compare
|
Cool, done. |
bors-servo
pushed a commit
that referenced
this pull request
Oct 8, 2014
Note that using `servo --devtools http://example.org` doesn't work. In that case either the port must be specified or the option moved to the end. But this is the same for other such options, e.g. `--profile`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that using
servo --devtools http://example.orgdoesn't work. Inthat case either the port must be specified or the option moved to the
end. But this is the same for other such options, e.g.
--profile.