Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mach to build openssl on android instead of glut makefile. #4292

Merged
merged 1 commit into from
Dec 9, 2014

Conversation

glennw
Copy link
Member

@glennw glennw commented Dec 8, 2014

The glut makefile will be removed shortly after glutin lands
for android, so we need to build openssl for android elsewhere
in the build process.

The glut makefile will be removed shortly after glutin lands
for android, so we need to build openssl for android elsewhere
in the build process.
@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/3426

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@glennw
Copy link
Member Author

glennw commented Dec 8, 2014

r? @larsbergstrom or @mbrubeck or @metajack

@jdm jdm added the S-awaiting-review There is new code that needs to be reviewed. label Dec 8, 2014
@mbrubeck mbrubeck added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Dec 9, 2014
bors-servo pushed a commit that referenced this pull request Dec 9, 2014
The glut makefile will be removed shortly after glutin lands
for android, so we need to build openssl for android elsewhere
in the build process.
@bors-servo bors-servo closed this Dec 9, 2014
@bors-servo bors-servo merged commit 030dab5 into servo:master Dec 9, 2014
@glennw glennw deleted the android-ssl branch December 11, 2014 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants