New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TextInput: set_content
sets wrong edit_point
#4622
Labels
A-content/editing
User input related to text editing
Comments
bors-servo
pushed a commit
that referenced
this issue
Jan 18, 2015
Fixes #4622 Previously, when the edit point was being clamped leftward by a shortened line, it would be placed one one character too far to the left instead of at the very end. The "if" removed here was introduced in f686943 to fix a crash, but the underlying reason for the crash was the incorrect "- 1", which has been there since the beginning ( 80764f6 ).
bors-servo
pushed a commit
that referenced
this issue
Jan 18, 2015
Fixes #4622 Previously, when the edit point was being clamped leftward by a shortened line, it would be placed one one character too far to the left instead of at the very end. The "if" removed here was introduced in f686943 to fix a crash, but the underlying reason for the crash was the incorrect "- 1", which has been there since the beginning ( 80764f6 ).
bors-servo
pushed a commit
that referenced
this issue
Jan 18, 2015
Fixes #4622 Previously, when the edit point was being clamped leftward by a shortened line, it would be placed one one character too far to the left instead of at the very end. The "if" removed here was introduced in f686943 to fix a crash, but the underlying reason for the crash was the incorrect "- 1", which has been there since the beginning ( 80764f6 ).
bors-servo
pushed a commit
that referenced
this issue
Jan 18, 2015
Fixes #4622 Previously, when the edit point was being clamped leftward by a shortened line, it would be placed one one character too far to the left instead of at the very end. The "if" removed here was introduced in f686943 to fix a crash, but the underlying reason for the crash was the incorrect "- 1", which has been there since the beginning ( 80764f6 ).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In my ongoing pull request for unit test for
TextInput
it looks like theedit_point
is wrong ifset_content
is used in some cases.From #4569 (comment):
From https://github.com/donaldpipowitch/servo/blob/6ce72e60b70fa43f7006576a02465d64f7f8c997/components/script/textinput.rs#L492:
The text was updated successfully, but these errors were encountered: