Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warning #4943

Merged
merged 1 commit into from
Feb 18, 2015
Merged

Remove warning #4943

merged 1 commit into from
Feb 18, 2015

Conversation

thiagopnts
Copy link
Contributor

Remove warning from unused import

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/4006

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@glennw
Copy link
Member

glennw commented Feb 17, 2015

@thiagopnts That import is required on Linux but not other platforms.

@Manishearth
Copy link
Member

You can make it a separate import with #[cfg(target_os = "linux")] to kill the warning.

Alternatively, just place the import inside the function body where it is used (https://github.com/thiagopnts/servo/blob/remove-warnings/ports/glutin/window.rs#L513)

@Manishearth Manishearth added the S-needs-code-changes Changes have not yet been made that were requested by a reviewer. label Feb 17, 2015
@thiagopnts
Copy link
Contributor Author

@glennw @Manishearth I added the import on the function body!

@jdm jdm added S-awaiting-review There is new code that needs to be reviewed. and removed S-needs-code-changes Changes have not yet been made that were requested by a reviewer. labels Feb 17, 2015
@glennw
Copy link
Member

glennw commented Feb 17, 2015

Thanks! Can you squash these into one commit and then I'll merge it :)

@jdm jdm added S-needs-squash Some (or all) of the commits in the PR should be combined. and removed S-awaiting-review There is new code that needs to be reviewed. labels Feb 17, 2015
Add import for linux only
@thiagopnts
Copy link
Contributor Author

@glennw Done!

bors-servo pushed a commit that referenced this pull request Feb 18, 2015
@bors-servo bors-servo closed this Feb 18, 2015
@bors-servo bors-servo merged commit 211a134 into servo:master Feb 18, 2015
@thiagopnts thiagopnts deleted the remove-warnings branch February 18, 2015 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-needs-squash Some (or all) of the commits in the PR should be combined.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants