Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CanvasRenderingContext2d.drawImage fo HTMLImage as ImageSource #5290

Closed
dmarcos opened this issue Mar 20, 2015 · 3 comments
Closed

Implement CanvasRenderingContext2d.drawImage fo HTMLImage as ImageSource #5290

dmarcos opened this issue Mar 20, 2015 · 3 comments

Comments

@dmarcos
Copy link
Contributor

@dmarcos dmarcos commented Mar 20, 2015

@jdm Is it ok if I work on this as a follow up of #4784?

@jdm
Copy link
Member

@jdm jdm commented Mar 20, 2015

Of course!

@dmarcos
Copy link
Contributor Author

@dmarcos dmarcos commented Mar 28, 2015

@jdm Hi there! I'm back with more newbie rust code. Slowly getting into the groove :)

#5433

Special attention has to be paid to the part where I retrieve the image data from cache:

https://github.com/servo/servo/pull/5433/files#diff-73749ed78090d6d7ef64586d558e0850R226

@jdm
Copy link
Member

@jdm jdm commented Jan 5, 2017

Fixed by #5433.

@jdm jdm closed this Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.