Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the HTMLInputElement's placeholder attribute #5378

Closed
jdm opened this issue Mar 26, 2015 · 3 comments
Closed

Implement the HTMLInputElement's placeholder attribute #5378

jdm opened this issue Mar 26, 2015 · 3 comments
Labels
A-forms C-assigned There is someone working on resolving the issue E-less-complex Straightforward. Recommended for a new contributor.

Comments

@jdm
Copy link
Member

jdm commented Mar 26, 2015

Spec: https://html.spec.whatwg.org/multipage/forms.html#the-placeholder-attribute
Code: components/script/dom/webidls/HTMLInputElement.webidl, components/script/dom/htmlinputelement.rs

In particular, this should be the fallback for get_raw_textinput_value when it would otherwise return an empty string.
@jdm jdm added E-less-complex Straightforward. Recommended for a new contributor. A-forms labels Mar 26, 2015
@minsumm
Copy link
Contributor

minsumm commented Mar 26, 2015

I've been working on this, but I'm slightly hesitant with my choices, as this is my second day with
Rust & servo.

Anyhow: #5385

@jdm jdm added the C-assigned There is someone working on resolving the issue label Mar 26, 2015
@bgdncz
Copy link
Contributor

bgdncz commented Apr 5, 2015

So, has this been fixed?

@jdm
Copy link
Member Author

jdm commented Apr 5, 2015

It has; sorry.

@jdm jdm closed this as completed Apr 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-forms C-assigned There is someone working on resolving the issue E-less-complex Straightforward. Recommended for a new contributor.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jdm @minsumm @bgdncz