Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get the barest bones of webdriver integration ready for keeners. #5415

Merged
merged 1 commit into from
Apr 7, 2015
Merged

Get the barest bones of webdriver integration ready for keeners. #5415

merged 1 commit into from
Apr 7, 2015

Conversation

jdm
Copy link
Member

@jdm jdm commented Mar 27, 2015

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/4403

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@jdm
Copy link
Member Author

jdm commented Mar 27, 2015

This will allow me to file issues for people to work on integration in pieces, and will force us to keep webdriver-rust up to date with rustc upgrades.

@jdm jdm added the S-awaiting-review There is new code that needs to be reviewed. label Mar 27, 2015
@metajack
Copy link
Contributor

Assigned @pcwalton.

pcwalton
pcwalton reviewed Apr 1, 2015
View reviewed changes
components/util/opts.rs
@@ -226,6 +231,7 @@ pub fn from_cmdline_args(args: &[String]) -> bool {
getopts::optflag("z", "headless", "Headless mode"),
getopts::optflag("f", "hard-fail", "Exit on task failure instead of displaying about:failure"),
getopts::optflagopt("", "devtools", "Start remote devtools server on port", "6000"),
getopts::optflagopt("", "webdriver", "Start remote devtools server on port", "7000"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/devtools/webdriver/?

@jdm jdm added S-needs-code-changes Changes have not yet been made that were requested by a reviewer. and removed S-awaiting-review There is new code that needs to be reviewed. labels Apr 1, 2015
@jdm
Copy link
Member Author

jdm commented Apr 6, 2015

r? @pcwalton

@jdm jdm added S-awaiting-review There is new code that needs to be reviewed. and removed S-needs-code-changes Changes have not yet been made that were requested by a reviewer. labels Apr 6, 2015
@pcwalton
Copy link
Contributor

pcwalton commented Apr 6, 2015

r+

@bors-servo
Copy link
Contributor

📌 Commit 4dfb65e has been approved by pcwalton

@jdm jdm added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Apr 6, 2015
bors-servo pushed a commit that referenced this pull request Apr 6, 2015
Auto merge of #5415 - jdm:webdriver, r=pcwalton
8e84174 
Requires mozilla/webdriver-rust#6.
@bors-servo
Copy link
Contributor

⌛ Testing commit 4dfb65e with merge 8e84174...

@bors-servo
Copy link
Contributor

💔 Test failed - gonk

@jdm jdm added S-needs-code-changes Changes have not yet been made that were requested by a reviewer. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Apr 6, 2015
@jdm
Copy link
Member Author

jdm commented Apr 6, 2015

@bors-servo: r+

@bors-servo
Copy link
Contributor

📌 Commit 5728799 has been approved by jdm

@jdm jdm added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-needs-code-changes Changes have not yet been made that were requested by a reviewer. labels Apr 6, 2015
@Manishearth
Copy link
Member

@bors-servo: force

@Manishearth
Copy link
Member

@bors-servo: p=2

@bors-servo
Copy link
Contributor

⌛ Testing commit 5728799 with merge e3f93d5...

bors-servo pushed a commit that referenced this pull request Apr 6, 2015
Auto merge of #5415 - jdm:webdriver, r=jdm
e3f93d5 
Requires mozilla/webdriver-rust#6.
@Manishearth Manishearth closed this Apr 7, 2015
@Manishearth Manishearth reopened this Apr 7, 2015
@bors-servo
Copy link
Contributor

⌛ Testing commit 5728799 with merge f373645...

bors-servo pushed a commit that referenced this pull request Apr 7, 2015
Auto merge of #5415 - jdm:webdriver, r=jdm
f373645 
Requires mozilla/webdriver-rust#6.
@larsbergstrom larsbergstrom reopened this Apr 7, 2015
@bors-servo
Copy link
Contributor

⌛ Testing commit 5728799 with merge 1f57c6d...

bors-servo pushed a commit that referenced this pull request Apr 7, 2015
Auto merge of #5415 - jdm:webdriver, r=jdm
1f57c6d 
Requires mozilla/webdriver-rust#6.
@bors-servo
Copy link
Contributor

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2

@bors-servo bors-servo merged commit 5728799 into servo:master Apr 7, 2015
@jdm jdm deleted the webdriver branch August 4, 2015 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pcwalton pcwalton

Labels
S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jdm @hoppipolla-critic-bot @metajack @pcwalton @bors-servo @Manishearth @larsbergstrom