Use a faster scroll speed under X11 #6373
Conversation
highfive
added
the
S-awaiting-review
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @Ms2ger (or someone else) soon. |
|
Critic review: https://critic.hoppipolla.co.uk/r/5275 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
Great! I'm currently working on cherry-picking over your Glutin change. |
|
Thanks @pcwalton! - A related question - what's the current thinking on CEF vs glutin for the Servo goal of an alpha browser this year? I saw there was discussion about whether to support multiple ports or just CEF but I couldn't see what the final outcome was. |
|
There hasn't been a final decision AFAIK—thanks for reminding me, since I should bring it up again. I'm still in favor of going CEF-only and recreating the Glutin shell in terms of CEF. |
|
@robertknight We've merged the change to Glutin in servo/glutin. Can you update to that commit in this PR? r=me with that. |
|
@bors-servo: r+ |
|
📌 Commit 89e9aa0 has been approved by |
…alton Use a faster scroll speed under X11 Platforms may report scroll deltas either in chunks/lines/rows or pixels, depending on the platform API and device capabilities. If the platform reports a line/chunk-based delta then the application needs to convert the delta into a suitable number of pixels. Apple's documentation for example states that the app should interpret the delta as a number of lines or rows to scroll, depending on the type of view. This commit just hardcodes it to 57 as a starting point which matches the value that Firefox calculates as the max char height for the root frame on my system. This depends on this Glutin PR: rust-windowing/glutin#483 Fixes #5660 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6373) <!-- Reviewable:end -->
|
💔 Test failed - mac2 |
|
@robertknight Looks like Mac didn't compile. |
pcwalton
added
S-tests-failed
highfive
added
S-awaiting-review
|
There appears to be a merge commit on your PR branch; please rebase on master to get rid of it. |
robertknight
force-pushed
the
gh5660-rob-x11_scroll_speed
branch
2 times, most recently
from
87b2927
to
6f24583
Compare
|
@bors-servo: r+ |
|
📌 Commit 6f24583 has been approved by |
…alton Use a faster scroll speed under X11 Platforms may report scroll deltas either in chunks/lines/rows or pixels, depending on the platform API and device capabilities. If the platform reports a line/chunk-based delta then the application needs to convert the delta into a suitable number of pixels. Apple's documentation for example states that the app should interpret the delta as a number of lines or rows to scroll, depending on the type of view. This commit just hardcodes it to 57 as a starting point which matches the value that Firefox calculates as the max char height for the root frame on my system. This depends on this Glutin PR: rust-windowing/glutin#483 Fixes #5660 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6373) <!-- Reviewable:end -->
|
💔 Test failed - mac2 |
|
This doesn't build due to a missing glutin import |
Platforms may report scroll deltas either in chunks/lines/rows or pixels, depending on the platform API and device capabilities. If the platform reports a line/chunk-based delta then the application needs to convert the delta into a suitable number of pixels. This commit just hardcodes it to 57 as a starting point which matches the value that Firefox calculates as the max char height for the root frame on my system. Fixes servo#5660
robertknight
force-pushed
the
gh5660-rob-x11_scroll_speed
branch
from
6f24583
to
658df60
Compare
|
Sorry @pcwalton - I hadn't updated the glutin dependency in Cargo.lock for the CEF port. It hadn't occurred to me that used glutin as well. I've just pushed a fix for that. Is there a better way to keep the various Cargo.lock files in sync? |
|
@bors-servo: r+ |
|
📌 Commit 658df60 has been approved by |
…alton Use a faster scroll speed under X11 Platforms may report scroll deltas either in chunks/lines/rows or pixels, depending on the platform API and device capabilities. If the platform reports a line/chunk-based delta then the application needs to convert the delta into a suitable number of pixels. Apple's documentation for example states that the app should interpret the delta as a number of lines or rows to scroll, depending on the type of view. This commit just hardcodes it to 57 as a starting point which matches the value that Firefox calculates as the max char height for the root frame on my system. This depends on this Glutin PR: rust-windowing/glutin#483 Fixes #5660 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6373) <!-- Reviewable:end -->
|
\o/ Thanks for your hard work on this! |
Platforms may report scroll deltas either in
chunks/lines/rows or pixels, depending on the
platform API and device capabilities.
If the platform reports a line/chunk-based delta
then the application needs to convert the delta
into a suitable number of pixels. Apple's documentation for example states
that the app should interpret the delta as a number of lines or rows to scroll,
depending on the type of view.
This commit just hardcodes it to 57 as
a starting point which matches the value that
Firefox calculates as the max char height
for the root frame on my system.
This depends on this Glutin PR: rust-windowing/glutin#483
Fixes #5660