Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utilize iterators for AttrValue::from_serialized_tokenlist #6556

Merged
merged 1 commit into from
Jul 5, 2015
Merged

Utilize iterators for AttrValue::from_serialized_tokenlist #6556

merged 1 commit into from
Jul 5, 2015

Conversation

frewsxcv
Copy link
Contributor

@frewsxcv frewsxcv commented Jul 5, 2015

Review on Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jul 5, 2015
@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/5468

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@Ms2ger
Copy link
Contributor

Ms2ger commented Jul 5, 2015

I guess.

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit a985ee4 has been approved by Ms2ger

@bors-servo
Copy link
Contributor

⌛ Testing commit a985ee4 with merge 0fb6604...

bors-servo pushed a commit that referenced this pull request Jul 5, 2015
Auto merge of #6556 - frewsxcv:AttrValue-from_serialized_tokenlist, r…
0fb6604 
…=Ms2ger

Utilize iterators for AttrValue::from_serialized_tokenlist



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6556)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, gonk, linux1, linux2, linux3, mac1, mac2, mac3

@bors-servo bors-servo merged commit a985ee4 into servo:master Jul 5, 2015
@frewsxcv frewsxcv deleted the AttrValue-from_serialized_tokenlist branch October 9, 2015 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-review There is new code that needs to be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@frewsxcv @hoppipolla-critic-bot @Ms2ger @bors-servo @highfive