Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic unit test for preload_hsts_domains. #6793

Merged
merged 1 commit into from
Jul 29, 2015
Merged

Add basic unit test for preload_hsts_domains. #6793

merged 1 commit into from
Jul 29, 2015

Conversation

notriddle
Copy link
Contributor

Closes #6789.

Review on Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jul 27, 2015
@jdm
Copy link
Member

jdm commented Jul 27, 2015

Thanks! Have you checked that the test fails if you add invalid JSON to the file?

@notriddle
Copy link
Contributor Author

Just did, and it fails right.

@jdm
Copy link
Member

jdm commented Jul 27, 2015

@bors-servo: r+
Fantastic!

@bors-servo
Copy link
Contributor

📌 Commit 1339b8c has been approved by jdm

@jdm jdm added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jul 27, 2015
@bors-servo
Copy link
Contributor

⌛ Testing commit 1339b8c with merge 963b91a...

bors-servo pushed a commit that referenced this pull request Jul 28, 2015
Auto merge of #6793 - notriddle:hsts-preload, r=jdm
963b91a 
Add basic unit test for `preload_hsts_domains`.

Closes #6789.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6793)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux3

@jdm
Copy link
Member

jdm commented Jul 29, 2015

@bors-servo: retry

@bors-servo
Copy link
Contributor

⌛ Testing commit 1339b8c with merge 2df88ee...

bors-servo pushed a commit that referenced this pull request Jul 29, 2015
Auto merge of #6793 - notriddle:hsts-preload, r=jdm
2df88ee 
Add basic unit test for `preload_hsts_domains`.

Closes #6789.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6793)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, gonk, linux1, linux2, linux3, mac1, mac2, mac3

@bors-servo bors-servo merged commit 1339b8c into servo:master Jul 29, 2015
@notriddle notriddle deleted the hsts-preload branch July 29, 2015 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@notriddle @jdm @bors-servo @highfive