Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use local slice_chars #6876

Merged
merged 1 commit into from
Jul 31, 2015
Merged

Use local slice_chars #6876

merged 1 commit into from
Jul 31, 2015

Conversation

metajack
Copy link
Contributor

StrExt::slice_chars is deprecated and will be removed in Rust. This
lifts the implementation from Rust libstd and puts it in util::str.

This fixes a bunch of deprecation warnings in Servo.

Review on Reviewable

@metajack
Use local slice_chars
dae1a39 
StrExt::slice_chars is deprecated and will be removed in Rust. This
lifts the implementation from Rust libstd and puts it in util::str.

This fixes a bunch of deprecation warnings in Servo.
@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jul 31, 2015
@highfive
Copy link

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!

@metajack
Copy link
Contributor Author

r? @SimonSapin

@pcwalton
Copy link
Contributor

@bors-servo: r+

Assuming that slice_chars was indeed copy-and-pasted properly

@bors-servo
Copy link
Contributor

📌 Commit dae1a39 has been approved by pcwalton

@bors-servo
Copy link
Contributor

⌛ Testing commit dae1a39 with merge a54404c...

bors-servo pushed a commit that referenced this pull request Jul 31, 2015
Auto merge of #6876 - metajack:slice_chars-layout, r=pcwalton
a54404c 
Use local slice_chars

StrExt::slice_chars is deprecated and will be removed in Rust. This
lifts the implementation from Rust libstd and puts it in util::str.

This fixes a bunch of deprecation warnings in Servo.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6876)
<!-- Reviewable:end -->
@jdm jdm added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jul 31, 2015
@bors-servo
Copy link
Contributor

☀️ Test successful - android, gonk, linux1, linux2, linux3, mac1, mac2, mac3

@bors-servo bors-servo merged commit dae1a39 into servo:master Jul 31, 2015
This was referenced Jul 31, 2015
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SimonSapin SimonSapin

Labels
S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@metajack @highfive @pcwalton @bors-servo @jdm @SimonSapin