Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move net_error_list from net to net_traits. Fixes #7050. #7053

Merged
merged 1 commit into from
Aug 7, 2015
Merged

Move net_error_list from net to net_traits. Fixes #7050. #7053

merged 1 commit into from
Aug 7, 2015

Conversation

connorimes
Copy link
Contributor

Review on Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Aug 6, 2015
@highfive
Copy link

highfive commented Aug 6, 2015

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @mbrubeck (or someone else) soon.

@mbrubeck
Copy link
Contributor

mbrubeck commented Aug 6, 2015

Please run ./mach cargo-update -p compositing which should update the Cargo.lock files in ports/cef and ports/gonk.

@mbrubeck mbrubeck self-assigned this Aug 6, 2015
@mbrubeck mbrubeck added S-needs-code-changes Changes have not yet been made that were requested by a reviewer. and removed S-awaiting-review There is new code that needs to be reviewed. labels Aug 6, 2015
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-needs-code-changes Changes have not yet been made that were requested by a reviewer. labels Aug 6, 2015
@mbrubeck
Copy link
Contributor

mbrubeck commented Aug 6, 2015

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit b526214 has been approved by mbrubeck

@jdm jdm added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Aug 6, 2015
@bors-servo
Copy link
Contributor

⌛ Testing commit b526214 with merge 44c4bb0...

bors-servo pushed a commit that referenced this pull request Aug 7, 2015
Auto merge of #7053 - connorimes:move-net-error-list, r=mbrubeck
44c4bb0 
Move net_error_list from net to net_traits. Fixes #7050.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7053)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2, mac3

@bors-servo bors-servo merged commit b526214 into servo:master Aug 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mbrubeck mbrubeck

Labels
S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@connorimes @highfive @mbrubeck @bors-servo @jdm