Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actually store the overflow for inline-block elements. #7588

Merged
merged 1 commit into from Sep 17, 2015
Merged

Actually store the overflow for inline-block elements. #7588

merged 1 commit into from Sep 17, 2015

Conversation

notriddle
Copy link
Contributor

Fixes #7571

Review on Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Sep 9, 2015
@notriddle
Copy link
Contributor Author

r? @pcwalton

@notriddle
Copy link
Contributor Author

r? @jdm

@highfive highfive assigned jdm and unassigned pcwalton Sep 11, 2015
@jdm
Copy link
Member

jdm commented Sep 11, 2015

Sorry, I'm no good for reviewing layout code. Let's try @mbrubeck.

@notriddle
Copy link
Contributor Author

Alright, then. r? @mbrubeck

@highfive highfive assigned mbrubeck and unassigned jdm Sep 11, 2015
@pcwalton
Copy link
Contributor

@bors-servo: r+

@bors-servo
Copy link
Contributor

📌 Commit 029af81 has been approved by pcwalton

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Sep 15, 2015
@bors-servo
Copy link
Contributor

⌛ Testing commit 029af81 with merge 578815c...

bors-servo pushed a commit that referenced this pull request Sep 15, 2015
Auto merge of #7588 - notriddle:master, r=pcwalton
578815c 
Actually store the overflow for inline-block elements.

Fixes #7571

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7588)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Sep 15, 2015
@jdm
Copy link
Member

jdm commented Sep 15, 2015

Sorry, this is #7625 again. We'll sort it out.

@notriddle
Copy link
Contributor Author

@bors-servo retry

@jdm
Copy link
Member

jdm commented Sep 17, 2015

@bors-servo: retry

@bors-servo
Copy link
Contributor

⌛ Testing commit 029af81 with merge 53670e6...

bors-servo pushed a commit that referenced this pull request Sep 17, 2015
Auto merge of #7588 - notriddle:master, r=pcwalton
53670e6 
Actually store the overflow for inline-block elements.

Fixes #7571

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7588)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Sep 17, 2015
@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-wpt

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Sep 17, 2015
@mbrubeck
Copy link
Contributor

@bors-servo retry

#7422

@bors-servo
Copy link
Contributor

⌛ Testing commit 029af81 with merge 9e914ca...

bors-servo pushed a commit that referenced this pull request Sep 17, 2015
Auto merge of #7588 - notriddle:master, r=pcwalton
9e914ca 
Actually store the overflow for inline-block elements.

Fixes #7571

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7588)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Sep 17, 2015
@bors-servo
Copy link
Contributor

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt

@bors-servo bors-servo merged commit 029af81 into servo:master Sep 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mbrubeck mbrubeck

Labels
S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@notriddle @jdm @pcwalton @bors-servo @mbrubeck @highfive