-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for Extra pointer dereferencing #7643
Conversation
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon. |
Build failed as expected. |
@jdramani Want to fix them, too? :) |
Oh, having looked at these changes, I would rather integrate this check into the existing |
Doesn't this make more sense as a |
@Manishearth: why would we want to override it? |
In case of APIs that handle generic container &Ts which don't have |
|
Almost there! Like @nox pointed out, this can't merge until the existing problems this picks up are fixed, too :) Reviewed 1 of 1 files at r1, 1 of 1 files at r2, 1 of 1 files at r3. python/tidy.py, line 310 [r4] (raw file): Comments from the review on Reviewable.io |
Reviewed 1 of 1 files at r4. Comments from the review on Reviewable.io |
☔ The latest upstream changes (presumably #7680) made this pull request unmergeable. Please resolve the merge conflicts. |
-S-awaiting-review -S-fails-tidy +S-needs-code-changes Reviewed 5 of 5 files at r5, 4 of 4 files at r6. Comments from the review on Reviewable.io |
It looks like you merged master when you should have rebased. Try rebasing over master:
|
Try copying the commands I gave. |
@@ -109,8 +109,9 @@ def check_by_line(file_name, contents): | |||
errors = itertools.chain( | |||
check_length(file_name, idx, line), | |||
check_whitespace(idx, line), | |||
check_whatwg_url(idx, line), | |||
check_whatwg_url(idx, line) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future, you should not remove these commas
8a836fb
to
66c1a6f
Compare
66c1a6f
to
9b1d234
Compare
9b1d234
to
2a99915
Compare
Pls take a look at this. Tell me if there is any problem |
Looks great! Thanks for sticking with it :) |
@bors-servo: r+ |
📌 Commit 2a99915 has been approved by |
Check for Extra pointer dereferencing Solves issue #7640 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7643) <!-- Reviewable:end -->
💔 Test failed - mac-rel-wpt |
@bors-servo retry |
Check for Extra pointer dereferencing Solves issue #7640 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7643) <!-- Reviewable:end -->
☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt |
Solves issue #7640