fixed the deprecated as_slice warning...
#7741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
highfive
added
the
S-awaiting-review
|
|
|
Hmm, we could have something else... |
|
Why not call slice::ref_slice instead of inlining it? |
|
Replacing safe code with unsafe code seems not great. This is making the code worse. What other workarounds are available for the lack of as_slice? |
|
Yep, I should've gone for |
wafflespeanut
force-pushed
the
warning_fix
branch
from
88944c4
to
188f5d4
Compare
| }, | ||
| None => { | ||
| let empty_arr: &[_] = &[]; | ||
| empty_arr |
There was a problem hiding this comment.
Can these two lines be combined into a single &[] expression?
wafflespeanut
force-pushed
the
warning_fix
branch
from
188f5d4
to
35d7ced
Compare
|
@bors-servo: r+ |
|
📌 Commit 35d7ced has been approved by |
highfive
added
S-awaiting-merge
|
Thanks! :) |
bors-servo
pushed a commit
that referenced
this pull request
Sep 25, 2015
fixed the deprecated `as_slice` warning... I've put its original implementation from [`core/option.rs`](http://doc.servo.org/src/core/option.rs.html#692) instead of the dear departed `as_slice` <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7741) <!-- Reviewable:end -->
|
☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've put its original implementation from
core/option.rsinstead of the dear departedas_slice