absolute iframe z-index is wrong #7796

paulrouget · 2015-09-30T07:23:49Z

<style>

  div, iframe {
    position: absolute;
    width: 200px;
    height: 200px;
  }

  iframe {
    display: block;
    top: 0px;
    left: 0px;
    border-width: 0;
    background: green;
  }

  div {
    left: 100px;
    top: 100px;
    background: red;
  }

</style>

<body>

  <iframe src='data:,foo'></iframe>
  <div> </div>

</body>

paulrouget · 2015-09-30T08:07:17Z

/cc @pcwalton

waddlesplash · 2015-09-30T15:01:07Z

Looks like the mimetypeless data: is being interpreted as HTML not plaintext. Is this already tracked somewhere?

jdm · 2015-09-30T15:49:14Z

Nope; please file it.

mrobinson · 2015-09-30T18:51:01Z

This could likely be caused by the fact that iframes always get layers. Currently only stacking contexts can have layers and they are always on the top of the display list. I confirmed that adding a z-index to the div (thus promoting it to a stacking context) fixes the ordering issue.

pcwalton · 2015-09-30T21:54:15Z

Probably has to wait on @mrobinson's work for multiple layers per stacking context then (or WebRender).

mrobinson · 2015-09-30T21:56:53Z

I think I'll try to fix this case first, since I think it is the most straight-forward.

paulrouget · 2015-10-06T04:05:24Z

Probably has to wait on @mrobinson's work for multiple layers per stacking context then (or WebRender).

@pcwalton Is that gonna take a long time? Just to know if I should try to work around this bug or wait.

mrobinson · 2015-10-06T05:03:29Z

@paulrouget The work is complete. I will have the next set of PRs posted for review tomorrow.


        Integrate iframes into the display list

Instead of always promoting iframes to StackingContexts, integrate them into the display list. This prevents stacking bugs when non-stacking-context elements should be drawn on top of iframes. To accomplish this, we add another step to ordering layer creation, where LayeredItems in the DisplayList are added to layers described by the LayerInfo structures collected at the end of the DisplayList. Unlayered items that follow these layered items are added to synthesized layers. Another result of this change is that iframe layers can be positioned directly at the location of the iframe fragment, eliminating the need for the SubpageLayerInfo struct entirely. Iframes are the first type of content treated this way, but this change opens up the possibility to properly order canvas and all other layered content that does not create a stacking context. Fixes servo#7566. Fixes servo#7796.

paulrouget · 2015-10-13T16:27:50Z

@mrobinson any update on these PRs?

mrobinson · 2015-10-13T16:41:43Z

The PR is #7950. @pcwalton gave a little feedback, for which I'll upload a patch quite soon. Hopefully it can land today.


        Integrate iframes into the display list

Instead of always promoting iframes to StackingContexts, integrate them into the display list. This prevents stacking bugs when non-stacking-context elements should be drawn on top of iframes. To accomplish this, we add another step to ordering layer creation, where LayeredItems in the DisplayList are added to layers described by the LayerInfo structures collected at the end of the DisplayList. Unlayered items that follow these layered items are added to synthesized layers. Another result of this change is that iframe layers can be positioned directly at the location of the iframe fragment, eliminating the need for the SubpageLayerInfo struct entirely. Iframes are the first type of content treated this way, but this change opens up the possibility to properly order canvas and all other layered content that does not create a stacking context. Fixes servo#7566. Fixes servo#7796.


        Integrate iframes into the display list

Instead of always promoting iframes to StackingContexts, integrate them into the display list. This prevents stacking bugs when non-stacking-context elements should be drawn on top of iframes. To accomplish this, we add another step to ordering layer creation, where LayeredItems in the DisplayList are added to layers described by the LayerInfo structures collected at the end of the DisplayList. Unlayered items that follow these layered items are added to synthesized layers. Another result of this change is that iframe layers can be positioned directly at the location of the iframe fragment, eliminating the need for the SubpageLayerInfo struct entirely. Iframes are the first type of content treated this way, but this change opens up the possibility to properly order canvas and all other layered content that does not create a stacking context. Fixes servo#7566. Fixes servo#7796.


        Integrate iframes into the display list

Instead of always promoting iframes to StackingContexts, integrate them into the display list. This prevents stacking bugs when non-stacking-context elements should be drawn on top of iframes. To accomplish this, we add another step to ordering layer creation, where LayeredItems in the DisplayList are added to layers described by the LayerInfo structures collected at the end of the DisplayList. Unlayered items that follow these layered items are added to synthesized layers. Another result of this change is that iframe layers can be positioned directly at the location of the iframe fragment, eliminating the need for the SubpageLayerInfo struct entirely. Iframes are the first type of content treated this way, but this change opens up the possibility to properly order canvas and all other layered content that does not create a stacking context. Fixes servo#7566. Fixes servo#7796.


        Integrate iframes into the display list

Instead of always promoting iframes to StackingContexts, integrate them into the display list. This prevents stacking bugs when non-stacking-context elements should be drawn on top of iframes. To accomplish this, we add another step to ordering layer creation, where LayeredItems in the DisplayList are added to layers described by the LayerInfo structures collected at the end of the DisplayList. Unlayered items that follow these layered items are added to synthesized layers. Another result of this change is that iframe layers can be positioned directly at the location of the iframe fragment, eliminating the need for the SubpageLayerInfo struct entirely. Iframes are the first type of content treated this way, but this change opens up the possibility to properly order canvas and all other layered content that does not create a stacking context. Fixes servo#7566. Fixes servo#7796.

paulrouget changed the title ~~Iframe z-index is wrong~~ absolute iframe z-index is wrong Sep 30, 2015

paulrouget mentioned this issue Sep 30, 2015

Servo + Browser.html: webplatform bugs browserhtml/browserhtml#562

Closed

62 of 92 tasks complete

jdm added A-gfx/displaylist A-layout/inline and removed A-gfx/displaylist labels Sep 30, 2015

waddlesplash mentioned this issue Sep 30, 2015

`data:` URI without mimetype is interpreted as HTML not plaintext #7803

Closed

mrobinson self-assigned this Oct 5, 2015

mrobinson closed this in ac5525a Oct 20, 2015

paulrouget added the A-browserhtml/P3 label Jan 26, 2016

servo / servo

absolute iframe z-index is wrong #7796

absolute iframe z-index is wrong #7796

paulrouget commented Sep 30, 2015

paulrouget commented Sep 30, 2015

waddlesplash commented Sep 30, 2015

jdm commented Sep 30, 2015

mrobinson commented Sep 30, 2015

pcwalton commented Sep 30, 2015

mrobinson commented Sep 30, 2015

paulrouget commented Oct 6, 2015

mrobinson commented Oct 6, 2015

paulrouget commented Oct 13, 2015

mrobinson commented Oct 13, 2015

servo / servo

Join GitHub today

absolute iframe z-index is wrong #7796

absolute iframe z-index is wrong #7796

Comments

paulrouget commented Sep 30, 2015

paulrouget commented Sep 30, 2015

waddlesplash commented Sep 30, 2015

jdm commented Sep 30, 2015

mrobinson commented Sep 30, 2015

pcwalton commented Sep 30, 2015

mrobinson commented Sep 30, 2015

paulrouget commented Oct 6, 2015

mrobinson commented Oct 6, 2015

paulrouget commented Oct 13, 2015

mrobinson commented Oct 13, 2015