Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Servo on Travis #7915

Merged
merged 1 commit into from Oct 8, 2015
Merged

Build Servo on Travis #7915

merged 1 commit into from Oct 8, 2015

Conversation

frewsxcv
Copy link
Contributor

@frewsxcv frewsxcv commented Oct 7, 2015

Closes #6962

Review on Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 7, 2015
@frewsxcv frewsxcv added S-needs-code-changes Changes have not yet been made that were requested by a reviewer. and removed S-awaiting-review There is new code that needs to be reviewed. labels Oct 7, 2015
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-needs-code-changes Changes have not yet been made that were requested by a reviewer. labels Oct 7, 2015
@frewsxcv frewsxcv force-pushed the travis branch 24 times, most recently from cc063b1 to d80568a Compare October 8, 2015 01:37
@frewsxcv frewsxcv force-pushed the travis branch 7 times, most recently from 6c56918 to f1d8a39 Compare October 8, 2015 04:10
@frewsxcv
Copy link
Contributor Author

frewsxcv commented Oct 8, 2015

Okay, this is ready to be reviewed. I learned that Travis CI runs on Ubuntu 12.04, which has a relatively old (and incompatible) version of libc. I thought about making libc compilation part of the build process but figured that would take too long. I noticed rust-lang/rust uses Docker to build on Travis. I decided to try that and fairly satisfied with how it turned out.

@frewsxcv frewsxcv mentioned this pull request Oct 8, 2015
Closed
@jdm
Copy link
Member

jdm commented Oct 8, 2015

😹

@Ms2ger
Copy link
Contributor

Ms2ger commented Oct 8, 2015

Can you try it with sudo: 9000?

@frewsxcv
Copy link
Contributor Author

frewsxcv commented Oct 8, 2015

Is sudo: 9000 documented somewhere?

@larsbergstrom
Copy link
Contributor

No. It lets us try a bigger instance type (and was passed on to us by the kind folks at Travis).

@frewsxcv
Copy link
Contributor Author

frewsxcv commented Oct 8, 2015

Alright, running with that now. Purposely made a new commit to compare runtime duration with the non-9000 build

@jdm
Copy link
Member

jdm commented Oct 8, 2015

Shaved a whole 13 seconds off the build :)

@larsbergstrom
Copy link
Contributor

I'll ask the Travis folks about that :-)

@frewsxcv
Copy link
Contributor Author

frewsxcv commented Oct 8, 2015

Any reason to hold off on merging this until then? i.e. What are the next steps here?

@larsbergstrom
Copy link
Contributor

Nope! I'd say squash and r=me.

CC @edunham (since we were talking about some Travis stuff recently)

@frewsxcv
Copy link
Contributor Author

frewsxcv commented Oct 8, 2015

@bors-servo r=larsbergstrom

@bors-servo
Copy link
Contributor

📌 Commit ad399bd has been approved by larsbergstrom

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Oct 8, 2015
@bors-servo
Copy link
Contributor

⌛ Testing commit ad399bd with merge e5b46eb...

bors-servo pushed a commit that referenced this pull request Oct 8, 2015
Auto merge of #7915 - frewsxcv:travis, r=larsbergstrom
e5b46eb 
Build Servo on Travis

Closes #6962

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7915)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt

@bors-servo bors-servo merged commit ad399bd into servo:master Oct 8, 2015
@frewsxcv frewsxcv deleted the travis branch October 8, 2015 15:46
@frewsxcv
Copy link
Contributor Author

frewsxcv commented Oct 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@frewsxcv @jdm @Ms2ger @larsbergstrom @bors-servo @highfive