-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Browser API: implement iframe.zoom() #8547
Comments
This will also need new code in the compositor to set the zoom of an iframe. Currently it only knows how to zoom the top-level window. |
Part of the fix for servo#8547. Does not work correctly because the compositor zooms the entire top-level window and not just the iframe.
@mbrubeck any update on this? |
No, sorry. Unassigning myself for now, but I'll try to get back to this soon if someone else doesn't fix it in the meantime. |
@mason-larobina Could you file a new issue for that? This one is tracking a DOM API for use in browser.html that has not been implemented yet. |
Done #12187 (Just to check, did you mean a servo or bhtml issue?) |
I meant servo. Thanks! |
We shipped the first alpha of browserhtml we are planning to move away from the Browser API. Closing. |
So I believe the right way to implement that is, from the iframe, send a constellation message with the subpage id, from constellation, get the scrip chan, send a zoom message, and in script_task.rs, handle the zoom message.
Then, I'm not sure when to perform the actual zooming. Should we append an event to the window and handle it
ScriptTask::handle_msgs
?If so, could we imagine instead using the resize event (which uses the same path) and add an extra parameter for the zoom value?
/cc @glennw
The text was updated successfully, but these errors were encountered: