Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser API: implement iframe.zoom() #8547

Closed
paulrouget opened this issue Nov 16, 2015 · 9 comments
Closed

Browser API: implement iframe.zoom() #8547

paulrouget opened this issue Nov 16, 2015 · 9 comments
Labels
A-content/dom Interacting with the DOM from web content A-gfx/compositing

Comments

@paulrouget
Copy link
Contributor

So I believe the right way to implement that is, from the iframe, send a constellation message with the subpage id, from constellation, get the scrip chan, send a zoom message, and in script_task.rs, handle the zoom message.

Then, I'm not sure when to perform the actual zooming. Should we append an event to the window and handle it ScriptTask::handle_msgs?

If so, could we imagine instead using the resize event (which uses the same path) and add an extra parameter for the zoom value?

/cc @glennw

@paulrouget
Copy link
Contributor Author

@jdm jdm added the A-content/dom Interacting with the DOM from web content label Nov 16, 2015
@mbrubeck mbrubeck self-assigned this Nov 17, 2015
@mbrubeck mbrubeck added C-assigned There is someone working on resolving the issue A-gfx/compositing labels Nov 17, 2015
@mbrubeck
Copy link
Contributor

This will also need new code in the compositor to set the zoom of an iframe. Currently it only knows how to zoom the top-level window.

mbrubeck added a commit to mbrubeck/servo that referenced this issue Nov 17, 2015
Part of the fix for servo#8547. Does not work correctly because the compositor
zooms the entire top-level window and not just the iframe.
@paulrouget
Copy link
Contributor Author

@mbrubeck any update on this?

@mbrubeck mbrubeck removed their assignment Feb 25, 2016
@mbrubeck
Copy link
Contributor

No, sorry. Unassigning myself for now, but I'll try to get back to this soon if someone else doesn't fix it in the meantime.

@jdm jdm removed the C-assigned There is someone working on resolving the issue label Feb 25, 2016
@mason-larobina
Copy link

Zooming the top-level window has unexpected results on my machine (though it could be a poor interaction with my window manager).

2016-07-02-140011_3200x1800_scrot

@jdm
Copy link
Member

jdm commented Jul 2, 2016

@mason-larobina Could you file a new issue for that? This one is tracking a DOM API for use in browser.html that has not been implemented yet.

@mason-larobina
Copy link

Done #12187

(Just to check, did you mean a servo or bhtml issue?)

@jdm
Copy link
Member

jdm commented Jul 2, 2016

I meant servo. Thanks!

@paulrouget
Copy link
Contributor Author

We shipped the first alpha of browserhtml we are planning to move away from the Browser API. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-content/dom Interacting with the DOM from web content A-gfx/compositing
Projects
None yet
Development

No branches or pull requests

4 participants