Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGL nits #8876

Merged
merged 2 commits into from Dec 7, 2015
Merged

WebGL nits #8876

merged 2 commits into from Dec 7, 2015

Conversation

emilio
Copy link
Member

@emilio emilio commented Dec 7, 2015

This improves support for running our triangle test (see: #8831), and adds missing error in BufferSubData

Review on Reviewable

@emilio
webgl: Use mediump in triangle test
89b65f3 
Support for this should be almost universal.
@emilio
webgl: Add correct error handling to BufferSubData
a14b605 
From the WebGL spec:

> If data is null then an INVALID_VALUE error is generated.
@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Dec 7, 2015
@emilio
Copy link
Member Author

emilio commented Dec 7, 2015

r? @jdm

@jdm
Copy link
Member

jdm commented Dec 7, 2015

@bors-servo: r+

@bors-servo
Copy link
Contributor

📌 Commit a14b605 has been approved by jdm

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Dec 7, 2015
@bors-servo
Copy link
Contributor

⌛ Testing commit a14b605 with merge 26de772...

bors-servo pushed a commit that referenced this pull request Dec 7, 2015
Auto merge of #8876 - ecoal95:webgl-nits, r=jdm
26de772 
WebGL nits

This improves support for running our triangle test (see: #8831), and adds missing error in `BufferSubData`

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8876)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Dec 7, 2015
@KiChjang
Copy link
Contributor

KiChjang commented Dec 7, 2015 

Ran 6932 tests finished in 964.0 seconds.
  • 6930 ran as expected. 8 tests skipped.
  • 2 tests timed out unexpectedly

Tests with unexpected results:
  ▶ TIMEOUT [expected FAIL] /css-flexbox-1_dev/html/flexbox-basic-iframe-vert-001.htm
  │ 
  │ was ready to save, resetting ready_to_save_state
  │ Shutting down the Constellation after generating an output file or exit flag specified
  │ was ready to save, resetting ready_to_save_state
  └ Shutting down the Constellation after generating an output file or exit flag specified

  ▶ TIMEOUT [expected FAIL] /css-flexbox-1_dev/html/flexbox-basic-iframe-horiz-001.htm
  │ 
  │ was ready to save, resetting ready_to_save_state
  │ Shutting down the Constellation after generating an output file or exit flag specified
  │ was ready to save, resetting ready_to_save_state
  └ Shutting down the Constellation after generating an output file or exit flag specified

@KiChjang
Copy link
Contributor

KiChjang commented Dec 7, 2015

@bors-servo retry

@jdm
Copy link
Member

jdm commented Dec 7, 2015

@bors-servo: retry

@bors-servo
Copy link
Contributor

⌛ Testing commit a14b605 with merge 743be46...

bors-servo pushed a commit that referenced this pull request Dec 7, 2015
Auto merge of #8876 - ecoal95:webgl-nits, r=jdm
743be46 
WebGL nits

This improves support for running our triangle test (see: #8831), and adds missing error in `BufferSubData`

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8876)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-dev

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. S-tests-failed The changes caused existing tests to fail. and removed S-tests-failed The changes caused existing tests to fail. S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Dec 7, 2015
@KiChjang
Copy link
Contributor

KiChjang commented Dec 7, 2015

@bors-servo retry

@bors-servo
Copy link
Contributor

⚡ Previous build results for android, gonk, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-dev, linux-rel...

@bors-servo
Copy link
Contributor

💔 Test failed - linux-dev

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Dec 7, 2015
@KiChjang KiChjang closed this Dec 7, 2015
@KiChjang KiChjang reopened this Dec 7, 2015
@KiChjang
Copy link
Contributor

KiChjang commented Dec 7, 2015

@bors-servo retry

@bors-servo
Copy link
Contributor

⌛ Testing commit a14b605 with merge d8f68a4...

bors-servo pushed a commit that referenced this pull request Dec 7, 2015
Auto merge of #8876 - ecoal95:webgl-nits, r=jdm
d8f68a4 
WebGL nits

This improves support for running our triangle test (see: #8831), and adds missing error in `BufferSubData`

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8876)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Dec 7, 2015
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Dec 7, 2015
@KiChjang
Copy link
Contributor

KiChjang commented Dec 7, 2015

@bors-servo retry

@bors-servo
Copy link
Contributor

⌛ Testing commit a14b605 with merge 9cccd34...

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Dec 7, 2015
bors-servo pushed a commit that referenced this pull request Dec 7, 2015
Auto merge of #8876 - ecoal95:webgl-nits, r=jdm
9cccd34 
WebGL nits

This improves support for running our triangle test (see: #8831), and adds missing error in `BufferSubData`

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8876)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt

@bors-servo bors-servo merged commit a14b605 into servo:master Dec 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@emilio @jdm @bors-servo @KiChjang @highfive