New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'test-tidy-faster' command to ./mach #9118
Conversation
I never have a FETCH_HEAD in my repository. |
@nox, that's inconvenient. Shall I instead use git log -n1 --author="bors-servo" --format="%H" to find the last merge? |
-S-awaiting-review +S-needs-decision Reviewed 1 of 3 files at r1, 2 of 2 files at r2. tests/wpt/web-platform-tests/tools/lint/lint.py, line 28 [r2] (raw file): So, this probably requires more work than I'd previously anticipated. I'll come up with a plan soon :) Comments from the review on Reviewable.io |
We could stick to the original plan:
Then we would not have to put any code in the WPT dir, but it would not be a very elegant (and probably just a temporary) solution. |
@dsprenkels Agreed, let's have |
Review status: 0 of 2 files reviewed at latest revision, 3 unresolved discussions. python/servo/testing_commands.py, line 262 [r3] (raw file): python/tidy.py, line 567 [r3] (raw file): python/tidy.py, line 595 [r3] (raw file): Comments from the review on Reviewable.io |
-S-awaiting-review +S-needs-code-changes Reviewed 2 of 3 files at r3. python/servo/testing_commands.py, line 262 [r3] (raw file): python/tidy.py, line 567 [r3] (raw file): python/tidy.py, line 595 [r3] (raw file): Comments from the review on Reviewable.io |
Review status: all files reviewed at latest revision, 3 unresolved discussions. python/tidy.py, line 567 [r3] (raw file): Comments from the review on Reviewable.io |
-S-awaiting-review +S-needs-squash Reviewed 2 of 2 files at r4. Comments from the review on Reviewable.io |
which will - only check files changed since the last merge by bors - and skip the wpt-lint
@bors-servo r+ Thanks! :) |
📌 Commit a9b8d47 has been approved by |
Add 'test-tidy-faster' command to ./mach For issue #9088, this adds a `--changes` option to `./mach test-tidy`. If this option is set, `tidy.py` will only check files that have been modified since `FETCH_HEAD`. Mention: @wafflespeanut <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9118) <!-- Reviewable:end -->
⛄ The build was interrupted to prioritize another pull request. |
⚡ Previous build results for gonk are reusable. Rebuilding only android, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt... |
⛄ The build was interrupted to prioritize another pull request. |
Add 'test-tidy-faster' command to ./mach For issue #9088, this adds a `--changes` option to `./mach test-tidy`. If this option is set, `tidy.py` will only check files that have been modified since `FETCH_HEAD`. Mention: @wafflespeanut <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9118) <!-- Reviewable:end -->
💔 Test failed - linux-rel |
Add 'test-tidy-faster' command to ./mach For issue #9088, this adds a `--changes` option to `./mach test-tidy`. If this option is set, `tidy.py` will only check files that have been modified since `FETCH_HEAD`. Mention: @wafflespeanut <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9118) <!-- Reviewable:end -->
WRATH OF THE BOTS!!! |
💔 Test failed - linux-rel |
⚡ Previous build results for android, gonk, linux-dev, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel... |
☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt |
Whoo! Finally! :) |
:D |
For issue #9088, this adds a
--changes
option to./mach test-tidy
. If this option is set,tidy.py
will only check files that have been modified sinceFETCH_HEAD
.Mention: @wafflespeanut