Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move DocumentState to script_traits #9224

Closed
jdm opened this issue Jan 9, 2016 · 2 comments
Closed

Move DocumentState to script_traits #9224

jdm opened this issue Jan 9, 2016 · 2 comments
Labels
C-assigned There is someone working on resolving the issue E-less-complex Straightforward. Recommended for a new contributor. I-refactor No impact; the issue is one of maintainability or tidiness. Proposed solution requires refactoring.

Comments

@jdm
Copy link
Member

jdm commented Jan 9, 2016

It's defined in msg but used by code that depends on script_traits.

Code: components/msg/constellation_msg.rs, components/script_traits/lib.rs
@jdm jdm added E-less-complex Straightforward. Recommended for a new contributor. I-refactor No impact; the issue is one of maintainability or tidiness. Proposed solution requires refactoring. labels Jan 9, 2016
@nerith
Copy link
Contributor

nerith commented Jan 12, 2016

I'd like to take this.

@nox
Copy link
Contributor

nox commented Jan 12, 2016

Sure!

@nox nox added the C-assigned There is someone working on resolving the issue label Jan 12, 2016
nerith added a commit to nerith/servo that referenced this issue Jan 12, 2016
@nerith
Move DocumentState to script_traits
d1186ed 
Fixes servo#9224.
@nerith nerith mentioned this issue Jan 12, 2016
Merged
bors-servo pushed a commit that referenced this issue Jan 12, 2016
Auto merge of #9279 - nerith:documentstate, r=nox
de8c2a9 
Move DocumentState to script_traits

Fixes #9224.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9279)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Jan 12, 2016
Auto merge of #9279 - nerith:documentstate, r=nox
cbb5a0d 
Move DocumentState to script_traits

Fixes #9224.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9279)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-assigned There is someone working on resolving the issue E-less-complex Straightforward. Recommended for a new contributor. I-refactor No impact; the issue is one of maintainability or tidiness. Proposed solution requires refactoring.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jdm @nox @nerith