Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename *_thread_source to *_task_source #9561

Closed
jdm opened this issue Feb 5, 2016 · 7 comments
Closed

Rename *_thread_source to *_task_source #9561

jdm opened this issue Feb 5, 2016 · 7 comments
Labels
C-assigned There is someone working on resolving the issue E-less-complex Straightforward. Recommended for a new contributor. I-cleanup No impact; the issue is one of maintainability or tidiness.

Comments

@jdm
Copy link
Member

jdm commented Feb 5, 2016

These were incorrectly renamed as part of #8522. These are terms from the specification which should refer to the concepts of "tasks", rather than the native concept of threads.

Code: components/script/dom/window.rs
@jdm jdm added E-less-complex Straightforward. Recommended for a new contributor. I-cleanup No impact; the issue is one of maintainability or tidiness. labels Feb 5, 2016
@kmuszyn
Copy link
Contributor

kmuszyn commented Feb 7, 2016

Hello, I think this looks like a good task for a complete newbie here, can I work on it?

@KiChjang
Copy link
Contributor

KiChjang commented Feb 8, 2016

Yes, definitely!

@KiChjang KiChjang added the C-assigned There is someone working on resolving the issue label Feb 8, 2016
kmuszyn added a commit to kmuszyn/servo that referenced this issue Feb 8, 2016
@kmuszyn
Issue servo#9561 Renamed *_thread_source to *_task_source in componen…
4260a42 
…ts/script/dom/window.rs
@kmuszyn kmuszyn mentioned this issue Feb 8, 2016
Merged
kmuszyn pushed a commit to kmuszyn/servo that referenced this issue Feb 13, 2016
Issue servo#9561 further renames: ThreadSource to TaskSource
0a8eee6
kmuszyn pushed a commit to kmuszyn/servo that referenced this issue Feb 13, 2016
Issue servo#9561 further renames: ThreadSource to TaskSource
2cb8a29
kmuszyn pushed a commit to kmuszyn/servo that referenced this issue Feb 14, 2016
Issue servo#9561 Renamed *_thread_source to *_task_source and ThreadS…
076cc40 
…ource to TaskSource
bors-servo pushed a commit that referenced this issue Feb 14, 2016
Auto merge of #9576 - kmuszyn:9561-rename-thread-to-task, r=jdm
c929dbe 
Issue #9561 Renamed *_thread_source to *_task_source window.rs

Related to: #9561

Renamed *thread_source to *_task_source in components/script/dom/window.rs and files that use window methods.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9576)
<!-- Reviewable:end -->
@timvandermeij
Copy link
Contributor

This can be closed now that #9576 has been merged.

@jdm jdm closed this as completed Feb 14, 2016
@KiChjang KiChjang reopened this Feb 16, 2016
@KiChjang KiChjang removed the C-assigned There is someone working on resolving the issue label Feb 16, 2016
@KiChjang
Copy link
Contributor

Sorry, this isn't done yet - git grep _thread_source still exposes a few instances where this isn't renamed.

cc @kmuszyn

@jdm
Copy link
Member Author

jdm commented Feb 16, 2016

Ah, I forgot to mention global.rs in the original comment.

@kmuszyn
Copy link
Contributor

kmuszyn commented Feb 16, 2016

Sorry, I missed that one. I will prepare a fix.

@jdm jdm added the C-assigned There is someone working on resolving the issue label Feb 16, 2016
kmuszyn added a commit to kmuszyn/servo that referenced this issue Feb 17, 2016
@kmuszyn
Issue servo#9561 continued - renamed *_thread_source to *_task_source…
c6dfd7e 
… in global.rs and related files
bors-servo pushed a commit that referenced this issue Feb 17, 2016
Auto merge of #9683 - kmuszyn:9561-more-thread-source-renamings, r=jdm
63dc161 
Issue #9561 continued - renamed *_thread_source to *_task_source

components/script/dom/bindings/global.rs modified -> all *_thread_source occurrences renamed to *_task_source to comply with spec

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9683)
<!-- Reviewable:end -->
@KiChjang
Copy link
Contributor

Fixed in #9683.

gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 1, 2019
@marco-c
servo: Merge #9576 - Issue #9561 Renamed *_thread_source to *_task_so…
716aad5 
…urce window.rs (from kmuszyn:9561-rename-thread-to-task); r=jdm

Related to: servo/servo#9561

Renamed *thread_source to *_task_source in components/script/dom/window.rs and files that use window methods.

Source-Repo: https://github.com/servo/servo
Source-Revision: c929dbe2530f979ce6e84d5a25ea47318ff0910e

UltraBlame original commit: 99548529a0ac8a6f1024a7c954a18dbe9cd83b5e
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 1, 2019
@marco-c
servo: Merge #9576 - Issue #9561 Renamed *_thread_source to *_task_so…
2904121 
…urce window.rs (from kmuszyn:9561-rename-thread-to-task); r=jdm

Related to: servo/servo#9561

Renamed *thread_source to *_task_source in components/script/dom/window.rs and files that use window methods.

Source-Repo: https://github.com/servo/servo
Source-Revision: c929dbe2530f979ce6e84d5a25ea47318ff0910e

UltraBlame original commit: 99548529a0ac8a6f1024a7c954a18dbe9cd83b5e
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 1, 2019
@marco-c
servo: Merge #9576 - Issue #9561 Renamed *_thread_source to *_task_so…
130a066 
…urce window.rs (from kmuszyn:9561-rename-thread-to-task); r=jdm

Related to: servo/servo#9561

Renamed *thread_source to *_task_source in components/script/dom/window.rs and files that use window methods.

Source-Repo: https://github.com/servo/servo
Source-Revision: c929dbe2530f979ce6e84d5a25ea47318ff0910e

UltraBlame original commit: 99548529a0ac8a6f1024a7c954a18dbe9cd83b5e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-assigned There is someone working on resolving the issue E-less-complex Straightforward. Recommended for a new contributor. I-cleanup No impact; the issue is one of maintainability or tidiness.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jdm @kmuszyn @timvandermeij @KiChjang