Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use rustdoc’s new --passes strip-priv-imports flag. #9894

Merged
merged 1 commit into from Mar 8, 2016
Merged

Use rustdoc’s new --passes strip-priv-imports flag. #9894

merged 1 commit into from Mar 8, 2016

Conversation

SimonSapin
Copy link
Member

rust-lang/rust#32055

This will make e.g. http://doc.servo.org/servo/index.html#reexports stop listing extern crate and use statements that don’t have pub.

Review on Reviewable

@SimonSapin
Use rustdoc’s new --passes strip-priv-imports flag.
f787e1a 
rust-lang/rust#32055

This will make e.g. http://doc.servo.org/servo/index.html#reexports
stop listing `extern crate` and `use` statements that don’t have `pub`.
@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 7, 2016
@Ms2ger
Copy link
Contributor

Ms2ger commented Mar 7, 2016

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit f787e1a has been approved by Ms2ger

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Mar 7, 2016
@nox nox assigned Ms2ger and unassigned larsbergstrom Mar 7, 2016
@Ms2ger Ms2ger mentioned this pull request Mar 7, 2016
Closed
@bors-servo
Copy link
Contributor

⌛ Testing commit f787e1a with merge 18dd8c8...

bors-servo pushed a commit that referenced this pull request Mar 7, 2016
Auto merge of #9894 - servo:strip-priv-imports, r=Ms2ger
18dd8c8 
Use rustdoc’s new `--passes strip-priv-imports` flag.

rust-lang/rust#32055

This will make e.g. http://doc.servo.org/servo/index.html#reexports stop listing `extern crate` and `use` statements that don’t have `pub`.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9894)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Mar 7, 2016
@jdm
Copy link
Member

jdm commented Mar 7, 2016

@bors-servo: retry

@bors-servo
Copy link
Contributor

⌛ Testing commit f787e1a with merge d8ecc2c...

bors-servo pushed a commit that referenced this pull request Mar 8, 2016
Auto merge of #9894 - servo:strip-priv-imports, r=Ms2ger
d8ecc2c 
Use rustdoc’s new `--passes strip-priv-imports` flag.

rust-lang/rust#32055

This will make e.g. http://doc.servo.org/servo/index.html#reexports stop listing `extern crate` and `use` statements that don’t have `pub`.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9894)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Mar 8, 2016
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Mar 8, 2016
@wafflespeanut
Copy link
Contributor 

Tests with unexpected results:
  ▶ TIMEOUT [expected OK] /html/rendering/replaced-elements/svg-embedded-sizing/svg-in-img-auto.html
  │ 
  │ thread 'LayoutWorker worker 1/12' panicked at 'called `Result::unwrap()` on an `Err` value: IoError(Error { repr: Os { code: 104, message: "Connection reset by peer" } })', ../src/libcore/result.rs:746
  │ stack backtrace:
  │    1:     0x7fd6779a8460 - sys::backtrace::tracing::imp::write::h578d6e47592a4041cHv
  │    2:     0x7fd6779ac71b - panicking::default_handler::_$u7b$$u7b$closure$u7d$$u7d$::closure.44995
  │    3:     0x7fd6779ac388 - panicking::default_handler::hffa00c845e94c6581nA
  │    4:     0x7fd6779963ac - sys_common::unwind::begin_unwind_inner::hd824946792143cc8vvu
  │    5:     0x7fd677996838 - sys_common::unwind::begin_unwind_fmt::h3777a045191296c5Buu
  │    6:     0x7fd6779a78d1 - rust_begin_unwind
  │    7:     0x7fd6779e379f - panicking::panic_fmt::h548fe28297c9d83b7mM
  │    8:     0x7fd676f3d7f0 - result::unwrap_failed::h5910243961065323276
  │    9:     0x7fd676f4fac1 - image_cache_thread::ImageCacheThread::find_image_or_metadata::hb1acfe78b133a8c78Qb
  │   10:     0x7fd676248992 - context::LayoutContext<'a>::get_or_request_image_or_meta::ha1d3df10af2139100Je
  │   11:     0x7fd6763a12d7 - fragment::ImageFragmentInfo::new::h386157881826269231
  │   12:     0x7fd6763a0fff - construct::FlowConstructor<'a, 'ln, ConcreteThreadSafeLayoutNode>::build_fragment_for_block::h1599187345687571620
  │   13:     0x7fd6763910cf - construct::FlowConstructor<'a, 'ln, ConcreteThreadSafeLayoutNode>.PostorderNodeMutTraversal<'ln, ConcreteThreadSafeLayoutNode>::process::h14582666686145034496
  │   14:     0x7fd676350f3e - traversal::RecalcStyleAndConstructFlows<'lc>.DomTraversalContext<'ln, ServoLayoutNode<'ln>>::process_postorder::h9b31a4861d877b75kwx
  │   15:     0x7fd67635afea - parallel::top_down_dom::h10997047908290674155
  │   16:     0x7fd6762a65c6 - sys_common::unwind::try::try_fn::h17716865604368154857
  │   17:     0x7fd6779a785b - __rust_try
  │   18:     0x7fd6779a445d - sys_common::unwind::inner_try::h8ac2089dadb4381bxsu
  │   19:     0x7fd6762a7d09 - boxed::F.FnBox<A>::call_box::h15825642985119982363
  │   20:     0x7fd6779ab1c9 - sys::thread::Thread::new::thread_start::hd111df90784ef3b2llz
  │   21:     0x7fd673ddb181 - start_thread
  │   22:     0x7fd6738f247c - __clone
  └   23:                0x0 - <unknown>

@wafflespeanut
Copy link
Contributor

@bors-servo retry

#9909

@bors-servo
Copy link
Contributor

⌛ Testing commit f787e1a with merge 1453f43...

bors-servo pushed a commit that referenced this pull request Mar 8, 2016
Auto merge of #9894 - servo:strip-priv-imports, r=Ms2ger
1453f43 
Use rustdoc’s new `--passes strip-priv-imports` flag.

rust-lang/rust#32055

This will make e.g. http://doc.servo.org/servo/index.html#reexports stop listing `extern crate` and `use` statements that don’t have `pub`.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9894)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Mar 8, 2016
@bors-servo
Copy link
Contributor

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, status-appveyor

@bors-servo bors-servo merged commit f787e1a into master Mar 8, 2016
@SimonSapin SimonSapin deleted the strip-priv-imports branch March 8, 2016 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ms2ger Ms2ger

Labels
S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@SimonSapin @Ms2ger @bors-servo @jdm @wafflespeanut @larsbergstrom @highfive