script: Disable our dependency in ffmpeg until the media madness is over #12863

emilio · 2016-08-14T22:47:43Z

r? @larsbergstrom

./mach build -d does not report any errors
./mach test-tidy does not report any errors.

This change is

highfive · 2016-08-14T22:47:46Z

Heads up! This PR modifies the following files:

@KiChjang: components/script/lib.rs, components/script/Cargo.toml, components/script/dom/htmlmediaelement.rs

highfive · 2016-08-14T22:47:47Z

Warning

These commits modify script code, but no tests are modified. Please consider adding a test!

emilio · 2016-08-14T22:47:51Z

@bors-servo: try

bors-servo · 2016-08-14T22:47:53Z

⌛ Trying commit 6f8a85b with merge d4a3ee5...


        Auto merge of #12863 - emilio:disable-media, r=<try>

@larsbergstrom

script: Disable our dependency in ffmpeg until the media madness is over  r? @larsbergstrom ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors.

emilio · 2016-08-14T22:48:02Z

cc @GuillaumeGomez

GuillaumeGomez · 2016-08-14T23:29:41Z

Wouldn't it better to put it behind a feature disabled by default?

emilio · 2016-08-14T23:30:52Z

@GuillaumeGomez I agree, but there might be licensing issues with linking ffmpeg, so that's why I removed it.

GuillaumeGomez · 2016-08-14T23:32:37Z

Any idea how firefox solved these license issues?

emilio · 2016-08-14T23:33:24Z

Not linking it, but dlopening it dinamically: #12687 (comment)

bors-servo · 2016-08-14T23:34:54Z

💔 Test failed - linux-rel

GuillaumeGomez · 2016-08-14T23:43:52Z

So if we use something along this, we could keep it, right? Wouldn't it be faster to add it in video-metadata-rs crate?

emilio · 2016-08-14T23:45:18Z

I don't know, maybe? I don't know for sure if linking it dynamically will solve all the problems either, that's a question maybe for @asajeffrey.

larsbergstrom · 2016-08-15T20:04:29Z

This will also need to disable the corresponding tests.

@GuillaumeGomez Should we do this, or do you think that we will move video-metadata-rs off of ffmpeg in the next day or so? We can certainly land this first to avoid rushing the PRs to that crate, and then turn everything back on later once the dependency is ready again.

asajeffrey · 2016-08-15T20:36:43Z

Usual IANAL disclaimer. The FFmpeg licensing page is at: https://www.ffmpeg.org/legal.html

The main requirements are:

Compile FFmpeg without --enable-gpl and without --enable-nonfree.
Use dynamic linking (on windows, this means linking to dlls) for linking with FFmpeg libraries.

There other items in their checklist, but there are the main two.

emilio · 2016-08-15T20:56:20Z

@larsbergstrom: tests updated

@bors-servo: try

bors-servo · 2016-08-15T20:56:24Z

⌛ Trying commit d200007 with merge b0ce5d2...


        Auto merge of #12863 - emilio:disable-media, r=<try>

@larsbergstrom

script: Disable our dependency in ffmpeg until the media madness is over  r? @larsbergstrom ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors.   --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12863)

bors-servo · 2016-08-15T21:43:32Z

💔 Test failed - linux-rel

highfive · 2016-08-15T21:43:34Z

  ▶ Unexpected subtest result in /html/semantics/embedded-content/media-elements/event_loadeddata.html:
  └ PASS [expected NOTRUN] setting src attribute on autoplay audio should trigger loadeddata event

  ▶ ERROR [expected TIMEOUT] /html/semantics/embedded-content/media-elements/interfaces/TextTrack/activeCues.html
  └   → TypeError: video.addTextTrack is not a function

emilio · 2016-08-15T23:27:34Z

@bors-servo: try


        Auto merge of #12863 - emilio:disable-media, r=<try>

@larsbergstrom

script: Disable our dependency in ffmpeg until the media madness is over  r? @larsbergstrom ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors.   --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12863)

emilio · 2016-08-17T22:07:00Z

@bors-servo: retry

That was my fault, I was investigating WebGL tests failures in the build
slave and I had a wpt socket already up, sorry

On 08/17/2016 02:34 PM, bors-servo wrote:

💔 Test failed - linux-rel
http://build.servo.org/builders/linux-rel/builds/2688

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#12863 (comment), or
mute the thread
https://github.com/notifications/unsubscribe-auth/ABQwuqacmxQ_eNVlkHUDWIWwMd-aHhMWks5qg35ygaJpZM4JkAW5.


        Auto merge of #12863 - emilio:disable-media, r=larsbergstrom

@larsbergstrom

script: Disable our dependency in ffmpeg until the media madness is over  r? @larsbergstrom ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors.   --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12863)

bors-servo · 2016-08-17T22:42:00Z

⌛ Testing commit b9f8905 with merge e994a7e...

bors-servo · 2016-08-17T23:28:11Z

💔 Test failed - linux-rel

highfive · 2016-08-17T23:28:13Z

  ▶ FAIL [expected PASS] /css-transforms-1_dev/html/perspective-origin-004.htm
  └   → /css-transforms-1_dev/html/perspective-origin-004.htm 68d5e8d6d5edcd2bef5ecaaf62cbbbac863dee22
/css-transforms-1_dev/html/reference/ref-filled-green-100px-square.htm d4aa213e3e31e41d0d8e84aec79e94f860f27178
Testing 68d5e8d6d5edcd2bef5ecaaf62cbbbac863dee22 == d4aa213e3e31e41d0d8e84aec79e94f860f27178

KiChjang · 2016-08-17T23:31:17Z

@bors-servo retry

#12891

bors-servo · 2016-08-18T00:49:48Z

⌛ Testing commit b9f8905 with merge fc1f4e9...


        Auto merge of #12863 - emilio:disable-media, r=larsbergstrom

@larsbergstrom

script: Disable our dependency in ffmpeg until the media madness is over  r? @larsbergstrom ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors.   --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12863)

bors-servo · 2016-08-18T01:44:41Z

💔 Test failed - linux-rel

cbrewster · 2016-08-18T16:22:01Z

@bors-servo retry

#12592

bors-servo · 2016-08-18T16:22:07Z

⌛ Testing commit b9f8905 with merge fb7cb92...


        Auto merge of #12863 - emilio:disable-media, r=larsbergstrom

@larsbergstrom

script: Disable our dependency in ffmpeg until the media madness is over  r? @larsbergstrom ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors.   --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12863)

bors-servo · 2016-08-18T17:20:21Z

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev

KiChjang · 2016-08-18T17:21:00Z

FINALLY!

highfive assigned larsbergstrom Aug 14, 2016

highfive added the S-awaiting-review label Aug 14, 2016

highfive added the S-tests-failed label Aug 14, 2016

emilio force-pushed the emilio:disable-media branch from 6f8a85b to d200007 Aug 15, 2016

highfive removed the S-tests-failed label Aug 15, 2016

highfive added the S-tests-failed label Aug 15, 2016

emilio force-pushed the emilio:disable-media branch from d200007 to 840172c Aug 15, 2016

highfive removed the S-tests-failed label Aug 15, 2016

highfive added S-awaiting-merge and removed S-tests-failed labels Aug 17, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels Aug 17, 2016

highfive added S-awaiting-merge and removed S-tests-failed labels Aug 18, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels Aug 18, 2016

metajack mentioned this pull request Aug 18, 2016

Windows Nightly blockers #12125

Closed

11 of 11 tasks complete

highfive added S-awaiting-merge and removed S-tests-failed labels Aug 18, 2016

bors-servo merged commit b9f8905 into servo:master Aug 18, 2016
2 checks passed

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Aug 18, 2016

This was referenced Aug 18, 2016

Burn SelectedFileId in fire #12898

Merged

Update to webrender 0.4.0 #12925

Merged

emilio deleted the emilio:disable-media branch Aug 18, 2016

servo / servo

script: Disable our dependency in ffmpeg until the media madness is over #12863

script: Disable our dependency in ffmpeg until the media madness is over #12863

emilio commented Aug 14, 2016 •

edited by larsbergstrom

highfive commented Aug 14, 2016

highfive commented Aug 14, 2016

emilio commented Aug 14, 2016

bors-servo commented Aug 14, 2016

emilio commented Aug 14, 2016

GuillaumeGomez commented Aug 14, 2016

emilio commented Aug 14, 2016

GuillaumeGomez commented Aug 14, 2016

emilio commented Aug 14, 2016 •

edited

bors-servo commented Aug 14, 2016

GuillaumeGomez commented Aug 14, 2016

emilio commented Aug 14, 2016

larsbergstrom commented Aug 15, 2016

asajeffrey commented Aug 15, 2016

emilio commented Aug 15, 2016

bors-servo commented Aug 15, 2016

bors-servo commented Aug 15, 2016

highfive commented Aug 15, 2016

emilio commented Aug 15, 2016

emilio commented Aug 17, 2016 •

edited

bors-servo commented Aug 17, 2016

bors-servo commented Aug 17, 2016

highfive commented Aug 17, 2016

KiChjang commented Aug 17, 2016

bors-servo commented Aug 18, 2016

bors-servo commented Aug 18, 2016

cbrewster commented Aug 18, 2016

bors-servo commented Aug 18, 2016

bors-servo commented Aug 18, 2016

KiChjang commented Aug 18, 2016

servo / servo

Join GitHub today

script: Disable our dependency in ffmpeg until the media madness is over #12863

script: Disable our dependency in ffmpeg until the media madness is over #12863

Conversation

emilio commented Aug 14, 2016 • edited by larsbergstrom

highfive commented Aug 14, 2016

highfive commented Aug 14, 2016

emilio commented Aug 14, 2016

bors-servo commented Aug 14, 2016

emilio commented Aug 14, 2016

GuillaumeGomez commented Aug 14, 2016

emilio commented Aug 14, 2016

GuillaumeGomez commented Aug 14, 2016

emilio commented Aug 14, 2016 • edited

bors-servo commented Aug 14, 2016

GuillaumeGomez commented Aug 14, 2016

emilio commented Aug 14, 2016

larsbergstrom commented Aug 15, 2016

asajeffrey commented Aug 15, 2016

emilio commented Aug 15, 2016

bors-servo commented Aug 15, 2016

bors-servo commented Aug 15, 2016

highfive commented Aug 15, 2016

emilio commented Aug 15, 2016

emilio commented Aug 17, 2016 • edited

bors-servo commented Aug 17, 2016

bors-servo commented Aug 17, 2016

highfive commented Aug 17, 2016

KiChjang commented Aug 17, 2016

bors-servo commented Aug 18, 2016

bors-servo commented Aug 18, 2016

cbrewster commented Aug 18, 2016

bors-servo commented Aug 18, 2016

bors-servo commented Aug 18, 2016

KiChjang commented Aug 18, 2016

emilio commented Aug 14, 2016 •

edited by larsbergstrom

emilio commented Aug 14, 2016 •

edited

emilio commented Aug 17, 2016 •

edited