Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CORS naming from 'CORS' to 'Cors'. #14156

Merged
merged 1 commit into from Nov 10, 2016
Merged

Update CORS naming from 'CORS' to 'Cors'. #14156

merged 1 commit into from Nov 10, 2016

Conversation

frewsxcv
Copy link
Contributor

@frewsxcv frewsxcv commented Nov 9, 2016 •
edited by larsbergstrom

As per:

https://aturon.github.io/style/naming/README.html#general-conventions-[rfc-#430]

Acronyms should be considered one word and not all caps.

This change is Reviewable

@highfive
Copy link

highfive commented Nov 9, 2016

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/request.rs, components/script/dom/xmlhttprequest.rs, components/script/dom/htmlscriptelement.rs
  • @KiChjang: components/script/dom/request.rs, components/net/fetch/methods.rs, components/net/fetch/cors_cache.rs, components/script/dom/xmlhttprequest.rs, components/net_traits/lib.rs, components/net_traits/lib.rs, components/script/dom/htmlscriptelement.rs, components/net_traits/response.rs, components/net_traits/response.rs, components/net_traits/request.rs, components/net_traits/request.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 9, 2016
@frewsxcv
Copy link
Contributor Author

frewsxcv commented Nov 9, 2016

@bors-servo p=-42

@KiChjang
Copy link
Contributor

KiChjang commented Nov 9, 2016

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit bf8752a has been approved by KiChjang

@highfive highfive assigned KiChjang and unassigned nox Nov 9, 2016
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Nov 9, 2016
@bors-servo
Copy link
Contributor

⌛ Testing commit bf8752a with merge e3f07df...

bors-servo pushed a commit that referenced this pull request Nov 10, 2016
Auto merge of #14156 - frewsxcv:cors-capitalization, r=KiChjang
e3f07df 
Update CORS naming from 'CORS' to 'Cors'.

As per:

https://aturon.github.io/style/naming/README.html#general-conventions-[rfc-#430]

Acronyms should be considered one word and not all caps.

<!-- Reviewable:start -->

---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14156)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-wpt1

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 10, 2016
@KiChjang
Copy link
Contributor

@bors-servo retry

@frewsxcv
Copy link
Contributor Author

Are you sure this isn't #13133 ?

@KiChjang
Copy link
Contributor

Browsing through linked issues in #11100, yes, I'm pretty sure #13133 is different.

@bors-servo
Copy link
Contributor

⚡ Previous build results for arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt2, windows-dev are reusable. Rebuilding only mac-rel-wpt1...

@bors-servo
Copy link
Contributor

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev

@bors-servo bors-servo merged commit bf8752a into servo:master Nov 10, 2016
@bors-servo bors-servo mentioned this pull request Nov 10, 2016
Merged
@frewsxcv frewsxcv deleted the cors-capitalization branch November 13, 2016 17:00
@frewsxcv frewsxcv mentioned this pull request Nov 14, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KiChjang KiChjang

Labels
S-tests-failed The changes caused existing tests to fail.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@frewsxcv @highfive @KiChjang @bors-servo @nox