New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intermittent timeout/crash in /html/dom/reflection-embedded.html #11100
Comments
I suspect this has something to do with the increased parallelism for wpt runs. @metajack ? |
I checked all the linked PRs. This intermittent appears isolated to mac-rel-wpt. |
I don't see anything in relection-embedded.html that would create files. Am I missing something? I can understand why we'd run out of file descriptors, but why always on this specific test? |
That's the one that handles |
All instances seem to be on servo-mac3 or servo-macpro1. |
On linux we seem to be happy with the default number of file descriptors (1024). We also run many more simultaneous tests on linux since there are more processors. On the mac, we attempt to set the limit to 30k via sysctl, but according to http://superuser.com/questions/302754/increase-the-maximum-number-of-open-file-descriptors-in-snow-leopard this is no longer enough. I have manually run Is there any reason why OS X runs would want more file descriptors than linux runs? |
Aha, I recently had to pave mac3 and macpro1 and I must have done something similarly manual that we haven't properly automated in salt yet that I didn't do when restoring them. Thanks! I thought that our linux machines were defaulting to unlimited the last time I checked. |
|
Note that this was consistent across servo-mac1, servo-mac2, servo-mac3, and servo-macpro1. I didn't find any configuration differences, but it is possible I missed something. |
This is what I used to do, pre-salt:
|
launchd.conf only exists on servo-mac2. All of them seem to have the /etc/profile change, and they also all had the sysctl.conf change (salt manages that one currently). |
I wonder if we used to run mac-rel-wpt on servo-mac2 before? That would explain why this popped up. |
@metajack Almost all our macs except for -mac2 have been paved in the last few weeks. I would not call OSX a stable OS for long-running automated systems :-) |
I'm unsure whether my changes were in effect for #11173, but it seems to have failed :( |
I spent some time investigating this to see whether it was opening excessive numbers of files. Here's a dtrace script I used:
This seems to show it does open a lot more files than say |
Consider disabling this since it's been hitting #14227 4 times in a row. |
Should help with servo#11100.
Use FnvHasher in http_loader::load Should help with #11100. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14284) <!-- Reviewable:end -->
Use FnvHasher in http_loader::load Should help with #11100. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14284) <!-- Reviewable:end -->
Disabling in #14293. |
Disable reflection-embedded.html. CC #11100 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14293) <!-- Reviewable:end -->
Disable reflection-embedded.html. CC #11100 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14293) <!-- Reviewable:end -->
Disable reflection-embedded.html. CC #11100 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14293) <!-- Reviewable:end -->
Disable reflection-embedded.html. CC #11100 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14293) <!-- Reviewable:end -->
The text was updated successfully, but these errors were encountered: