Deal with changes to the WebRender API #14200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up! This PR modifies the following files:
|
|
|
highfive
added
the
S-awaiting-review
|
@bors-servo try |
bors-servo
pushed a commit
that referenced
this pull request
Nov 14, 2016
Deal with changes to the WebRender API <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because they should not change behavior. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> The WebRender display list is now similar to the Servo display list, which simplifies the conversion.
Ms2ger
previously requested changes
Nov 14, 2016
| @@ -100,3 +100,7 @@ android_glue = "0.2" | |||
|
|
|||
| [target.'cfg(not(target_os = "windows"))'.dependencies] | |||
| gaol = {git = "https://github.com/servo/gaol"} | |||
|
|
|||
| [replace] | |||
| "webrender:0.8.0" = { path = '/home/martin/work/mozilla/webrender/webrender/' } | |||
There was a problem hiding this comment.
Yeah, that's not supposed to be there!
There was a problem hiding this comment.
Okay. I've cleaned this up. Sorry, this wasn't ready for review yet.
mrobinson
force-pushed
the
display-list
branch
from
27a6111
to
978f534
Compare
|
@bors-servo try |
bors-servo
pushed a commit
that referenced
this pull request
Nov 14, 2016
Deal with changes to the WebRender API <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because they should not change behavior. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> The WebRender display list is now similar to the Servo display list, which simplifies the conversion. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14200) <!-- Reviewable:end -->
|
☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev |
|
@mrobinson There was no shader change in that bump? |
|
@nox No, no shaders were updated as far as I can tell. |
|
@bors-servo r+ |
|
📌 Commit 978f534 has been approved by |
highfive
added
S-awaiting-merge
|
@bors-servo try- r+ clean |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit 978f534 has been approved by |
|
@bors-servo p=10 (Until this lands it's complicated working with a local WR override due to the version / API mismatch). |
|
@bors-servo retry |
bors-servo
pushed a commit
that referenced
this pull request
Nov 14, 2016
Deal with changes to the WebRender API <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because they should not change behavior. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> The WebRender display list is now similar to the Servo display list, which simplifies the conversion. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14200) <!-- Reviewable:end -->
|
⚡ Previous build results for arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev are reusable. Rebuilding only linux-rel-css, linux-rel-wpt... |
|
💔 Test failed - linux-rel-wpt |
|
|
⚡ Previous build results for arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev are reusable. Rebuilding only linux-rel-wpt... |
|
💔 Test failed - linux-rel-wpt |
|
mrobinson
force-pushed
the
display-list
branch
from
6b37d71
to
e62e2b4
Compare
highfive
added
S-awaiting-review
|
I extended the reftest-wait workaround to the other failing iframe test, perhaps it would be okay to try landing this one more time? |
mrobinson
force-pushed
the
display-list
branch
from
e62e2b4
to
386567e
Compare
|
@bors-servo try |
bors-servo
pushed a commit
that referenced
this pull request
Nov 16, 2016
Deal with changes to the WebRender API <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because they should not change behavior. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> The WebRender display list is now similar to the Servo display list, which simplifies the conversion. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14200) <!-- Reviewable:end -->
|
📌 Commit 386567e has been approved by |
highfive
added
S-awaiting-merge
|
I think the reftest-wait will help nothing, but it doesn't hurt either |
|
☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThe WebRender display list is now similar to the Servo display list,
which simplifies the conversion.
This change is