Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stylo: Hook property parsing into Gecko prefs #14999

Merged
merged 2 commits into from
Jan 14, 2017
Merged

stylo: Hook property parsing into Gecko prefs #14999

merged 2 commits into from
Jan 14, 2017

Conversation

Manishearth
Copy link
Member

@Manishearth Manishearth commented Jan 13, 2017 •
edited
Loading

r=heycam, https://bugzilla.mozilla.org/show_bug.cgi?id=1297322

This change is Reviewable

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @bholley: components/style/Cargo.toml, components/style/gecko_bindings/bindings.rs, components/style/gecko_bindings/structs_debug.rs, components/style/build_gecko.rs, components/style/gecko_bindings/structs_release.rs, components/style/properties/properties.mako.rs
  • @emilio: components/style/Cargo.toml, components/style/gecko_bindings/bindings.rs, components/style/gecko_bindings/structs_debug.rs, components/style/build_gecko.rs, components/style/gecko_bindings/structs_release.rs, components/style/properties/properties.mako.rs

@highfive
Copy link

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jan 13, 2017
@Manishearth
Copy link
Member Author

@bors-servo try

@bors-servo
Copy link
Contributor

⌛ Trying commit 40e91bf with merge d96a370...

bors-servo pushed a commit that referenced this pull request Jan 13, 2017
Auto merge of #14999 - Manishearth:stylo-prefs, r=<try>
d96a370 
stylo: Hook property parsing into Gecko prefs

r=heycam, https://bugzilla.mozilla.org/show_bug.cgi?id=1297322

This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14999)
<!-- Reviewable:end -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14999)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-dev

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Jan 13, 2017
@highfive highfive removed the S-tests-failed The changes caused existing tests to fail. label Jan 13, 2017
@Manishearth
Copy link
Member Author

@bors-servo try

@bors-servo
Copy link
Contributor

⌛ Trying commit 95ae90a with merge f44880b...

bors-servo pushed a commit that referenced this pull request Jan 13, 2017
Auto merge of #14999 - Manishearth:stylo-prefs, r=<try>
f44880b 
stylo: Hook property parsing into Gecko prefs

r=heycam, https://bugzilla.mozilla.org/show_bug.cgi?id=1297322

This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14999)
<!-- Reviewable:end -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14999)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-dev

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Jan 13, 2017
@highfive highfive removed the S-tests-failed The changes caused existing tests to fail. label Jan 13, 2017
@bors-servo
Copy link
Contributor

☔ The latest upstream changes (presumably #14968) made this pull request unmergeable. Please resolve the merge conflicts.

@highfive highfive added the S-needs-rebase There are merge conflict errors. label Jan 13, 2017
@Manishearth
stylo: Expose property-pref mappings
296b468 
MozReview-Commit-ID: 7evWOUFwa3K
@Manishearth
stylo: Hook property parsing into Gecko prefs
0572883 
MozReview-Commit-ID: 7evWOUFwa3K
@Manishearth
Copy link
Member Author

@bors-servo try- r=heycam

@bors-servo
Copy link
Contributor

📌 Commit 0572883 has been approved by heycam

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. S-needs-rebase There are merge conflict errors. labels Jan 14, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 0572883 with merge 4c401e4...

bors-servo pushed a commit that referenced this pull request Jan 14, 2017
Auto merge of #14999 - Manishearth:stylo-prefs, r=heycam
4c401e4 
stylo: Hook property parsing into Gecko prefs

r=heycam, https://bugzilla.mozilla.org/show_bug.cgi?id=1297322

This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14999)
<!-- Reviewable:end -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14999)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev

@bors-servo bors-servo merged commit 0572883 into servo:master Jan 14, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jan 14, 2017
@Manishearth Manishearth deleted the stylo-prefs branch January 14, 2017 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@heycam heycam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Manishearth @highfive @bors-servo @pcwalton @heycam