New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark the page source as loaded only after parsing is done #15098
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
...elements/loading-the-media-resource/resource-selection-invoke-pause-networkState.html.ini
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
[resource-selection-invoke-pause-networkState.html] | ||
type: testharness | ||
[NOT invoking resource selection with pause() when networkState is not NETWORK_EMPTY] | ||
expected: FAIL | ||
|
5 changes: 5 additions & 0 deletions
5
...g-the-media-resource/resource-selection-invoke-remove-from-document-networkState.html.ini
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
[resource-selection-invoke-remove-from-document-networkState.html] | ||
type: testharness | ||
[NOT invoking resource selection with implicit pause() when networkState is not NETWORK_EMPTY] | ||
expected: FAIL | ||
|
5 changes: 5 additions & 0 deletions
5
...nts/loading-the-media-resource/resource-selection-invoke-set-src-not-in-document.html.ini
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
[resource-selection-invoke-set-src-not-in-document.html] | ||
type: testharness | ||
[invoking load by setting src on video not in a document] | ||
expected: FAIL | ||
|
5 changes: 5 additions & 0 deletions
5
...tent/media-elements/loading-the-media-resource/resource-selection-invoke-set-src.html.ini
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
[resource-selection-invoke-set-src.html] | ||
type: testharness | ||
[invoking load by setting src] | ||
expected: FAIL | ||
|
2 changes: 0 additions & 2 deletions
2
tests/wpt/metadata/subresource-integrity/subresource-integrity.sub.html.ini
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
76 changes: 38 additions & 38 deletions
76
tests/wpt/web-platform-tests/old-tests/submission/Opera/script_scheduling/078.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,43 +1,43 @@ | ||
<!DOCTYPE html> | ||
<html> | ||
<head> | ||
<title> adding several types of scripts through the DOM and removing some of them confuses scheduler (slow-loading scripts) </title> | ||
<script src="/resources/testharness.js"></script> | ||
<script src="/resources/testharnessreport.js"></script> | ||
<script src="testlib/testlib.js"></script> | ||
<script type="text/javascript"> | ||
setup({explicit_done:true}); | ||
var head=document.getElementsByTagName('head')[0]; | ||
function createScript(url, contents) { | ||
props = {}; | ||
if (url) { | ||
props.src = url; | ||
} | ||
return testlib.addScript(contents, props, head, false); | ||
} | ||
var t = async_test(undefined, {timeout:10000}) | ||
<head> | ||
<title> adding several types of scripts through the DOM and removing some of them confuses scheduler (slow-loading scripts) </title> | ||
<script src="/resources/testharness.js"></script> | ||
<script src="/resources/testharnessreport.js"></script> | ||
<script src="testlib/testlib.js"></script> | ||
<script type="text/javascript"> | ||
setup({ explicit_done: true }); | ||
var head = document.getElementsByTagName('head')[0]; | ||
function createScript(url, contents) { | ||
props = {}; | ||
if (url) { | ||
props.src = url; | ||
} | ||
return testlib.addScript(contents, props, head, false); | ||
} | ||
var t = async_test(undefined, { timeout: 10000 }) | ||
|
||
function test() { | ||
document.getElementById("log").textContent = "Please wait..." | ||
var url = 'scripts/include-1.js?pipe=trickle(d1)'; | ||
var script = createScript(url); | ||
var script2 = createScript('', 'log("Script #2 ran")'); | ||
head.removeChild(script2); | ||
var url = 'scripts/include-2.js?pipe=trickle(d2)'; | ||
var script3 = createScript(url); | ||
head.removeChild(script3); | ||
function test() { | ||
document.getElementById("log").textContent = "Please wait..." | ||
var url = 'scripts/include-1.js?pipe=trickle(d1)'; | ||
var script = createScript(url); | ||
var script2 = createScript('', 'log("Script #2 ran")'); | ||
head.removeChild(script2); | ||
var url = 'scripts/include-2.js?pipe=trickle(d2)'; | ||
var script3 = createScript(url); | ||
head.removeChild(script3); | ||
|
||
setTimeout(t.step_func(function() { | ||
done(); | ||
assert_array_equals(eventOrder, ['Script #2 ran', 'external script #1', 'external script #2']); | ||
t.done(); | ||
}), 5500); | ||
setTimeout(t.step_func(function () { | ||
done(); | ||
assert_array_equals(eventOrder, ['Script #2 ran', 'external script #1', 'external script #2']); | ||
t.done(); | ||
}), 5500); | ||
|
||
}; | ||
onload = t.step_func(test) | ||
</script> | ||
</head> | ||
<body> | ||
<div id="log">FAILED (This TC requires JavaScript enabled)</div> | ||
</body> | ||
</html*> | ||
}; | ||
onload = t.step_func(test) | ||
</script> | ||
</head> | ||
<body> | ||
<div id="log">FAILED (This TC requires JavaScript enabled)</div> | ||
</body> | ||
</html> |
51 changes: 25 additions & 26 deletions
51
tests/wpt/web-platform-tests/old-tests/submission/Opera/script_scheduling/119.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,32 +1,31 @@ | ||
<!DOCTYPE html> | ||
<html><head> | ||
<title>scheduler: external defer script created with createContextualFragment</title> | ||
<script src="/resources/testharness.js"></script> | ||
<script src="/resources/testharnessreport.js"></script> | ||
<script src="testlib/testlib.js"></script> | ||
<title>scheduler: external defer script created with createContextualFragment</title> | ||
<script src="/resources/testharness.js"></script> | ||
<script src="/resources/testharnessreport.js"></script> | ||
<script src="testlib/testlib.js"></script> | ||
</head> | ||
<div id="log"></div> | ||
<script> | ||
log('inline script #1'); | ||
var t = async_test(); | ||
|
||
t.step(function() { | ||
var range = document.createRange(); | ||
var fragment = range.createContextualFragment("<script defer src='scripts/include-1.js?pipe=trickle(d1)'><\/script>"); | ||
document.body.appendChild(fragment.firstChild); | ||
}); | ||
|
||
addEventListener("DOMContentLoaded", t.step_func(function() { | ||
assert_array_equals(eventOrder, ['inline script #1', 'end inline script #1']); | ||
t.done(); | ||
})); | ||
<body> | ||
<div id="log"></div> | ||
<script> | ||
log('inline script #1'); | ||
var t = async_test(); | ||
|
||
addEventListener("load", t.step_func(function() { | ||
assert_array_equals(eventOrder, ['inline script #1', 'end inline script #1', 'external script #1']); | ||
t.done(); | ||
})); | ||
t.step(function () { | ||
var range = document.createRange(); | ||
var fragment = range.createContextualFragment("<script defer src='scripts/include-1.js?pipe=trickle(d1)'><\/script>"); | ||
document.body.appendChild(fragment.firstChild); | ||
}); | ||
|
||
log('end inline script #1'); | ||
</script> | ||
addEventListener("DOMContentLoaded", t.step_func(function () { | ||
assert_array_equals(eventOrder, ['inline script #1', 'end inline script #1']); | ||
})); | ||
|
||
addEventListener("load", t.step_func_done(function () { | ||
assert_array_equals(eventOrder, ['inline script #1', 'end inline script #1', 'external script #1']); | ||
})); | ||
|
||
log('end inline script #1'); | ||
</script> | ||
</body> | ||
</html> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should remove this variant and the code that handles it.