New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic handling framework for presentation attributes in Stylo, with handling for font-size and color #15331

Merged
merged 1 commit into from Feb 4, 2017

Conversation

Projects
None yet
5 participants
@Manishearth
Member

Manishearth commented Feb 1, 2017

@highfive

This comment has been minimized.

Show comment
Hide comment
@highfive

highfive Feb 1, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko_bindings/bindings.rs, components/style/gecko_bindings/sugar/ns_css_value.rs, components/style/gecko/wrapper.rs, components/style/values/specified/length.rs
  • @KiChjang: components/script/dom/htmlfontelement.rs
  • @fitzgen: components/script/dom/htmlfontelement.rs
  • @emilio: components/style/gecko_bindings/bindings.rs, ports/geckolib/glue.rs, components/style/gecko_bindings/sugar/ns_css_value.rs, components/style/gecko/wrapper.rs, components/style/values/specified/length.rs

highfive commented Feb 1, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko_bindings/bindings.rs, components/style/gecko_bindings/sugar/ns_css_value.rs, components/style/gecko/wrapper.rs, components/style/values/specified/length.rs
  • @KiChjang: components/script/dom/htmlfontelement.rs
  • @fitzgen: components/script/dom/htmlfontelement.rs
  • @emilio: components/style/gecko_bindings/bindings.rs, ports/geckolib/glue.rs, components/style/gecko_bindings/sugar/ns_css_value.rs, components/style/gecko/wrapper.rs, components/style/values/specified/length.rs
@highfive

This comment has been minimized.

Show comment
Hide comment
@highfive

highfive Feb 1, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style and script code, but no tests are modified. Please consider adding a test!

highfive commented Feb 1, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style and script code, but no tests are modified. Please consider adding a test!
@Manishearth

This comment has been minimized.

Show comment
Hide comment
@Manishearth

Manishearth Feb 1, 2017

Member

@bors-servo are you still there?

Member

Manishearth commented Feb 1, 2017

@bors-servo are you still there?

@Manishearth

This comment has been minimized.

Show comment
Hide comment
@Manishearth
Member

Manishearth commented Feb 1, 2017

@Manishearth

This comment has been minimized.

Show comment
Hide comment
@Manishearth

Manishearth Feb 1, 2017

Member

@bors-servo delegate=Manishearth

Member

Manishearth commented Feb 1, 2017

@bors-servo delegate=Manishearth

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Feb 1, 2017

Contributor

✌️ @Manishearth can now approve this pull request

Contributor

bors-servo commented Feb 1, 2017

✌️ @Manishearth can now approve this pull request

@Manishearth

This comment has been minimized.

Show comment
Hide comment
@Manishearth

Manishearth Feb 1, 2017

Member

@bors-servo are you still there?

Member

Manishearth commented Feb 1, 2017

@bors-servo are you still there?

1 similar comment
@Manishearth

This comment has been minimized.

Show comment
Hide comment
@Manishearth

Manishearth Feb 1, 2017

Member

@bors-servo are you still there?

Member

Manishearth commented Feb 1, 2017

@bors-servo are you still there?

@Manishearth

This comment has been minimized.

Show comment
Hide comment
@Manishearth

Manishearth Feb 2, 2017

Member

@bors-servo r=emilio,bz

Member

Manishearth commented Feb 2, 2017

@bors-servo r=emilio,bz

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Feb 2, 2017

Contributor

📌 Commit fdcb1fd has been approved by emilio,bz

Contributor

bors-servo commented Feb 2, 2017

📌 Commit fdcb1fd has been approved by emilio,bz

@highfive highfive assigned emilio and unassigned jdm Feb 2, 2017

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Feb 2, 2017

Contributor

⌛️ Testing commit fdcb1fd with merge ab78ac2...

Contributor

bors-servo commented Feb 2, 2017

⌛️ Testing commit fdcb1fd with merge ab78ac2...

bors-servo added a commit that referenced this pull request Feb 2, 2017

Auto merge of #15331 - Manishearth:stylo-presattr, r=emilio,bz
Basic handling framework for presentation attributes in Stylo, with handling for font-size and color

https://bugzilla.mozilla.org/show_bug.cgi?id=1330041

r=emilio,bz

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15331)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Feb 2, 2017

Contributor

💔 Test failed - mac-dev-unit

Contributor

bors-servo commented Feb 2, 2017

💔 Test failed - mac-dev-unit

@Manishearth

This comment has been minimized.

Show comment
Hide comment
@Manishearth

Manishearth Feb 2, 2017

Member

@bors-servo are you still there?

Member

Manishearth commented Feb 2, 2017

@bors-servo are you still there?

1 similar comment
@Manishearth

This comment has been minimized.

Show comment
Hide comment
@Manishearth

Manishearth Feb 2, 2017

Member

@bors-servo are you still there?

Member

Manishearth commented Feb 2, 2017

@bors-servo are you still there?

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Feb 2, 2017

Contributor

🍰 There you are

Contributor

bors-servo commented Feb 2, 2017

🍰 There you are

@Manishearth

This comment has been minimized.

Show comment
Hide comment
@Manishearth

Manishearth Feb 2, 2017

Member

@bors-servo r=emilio,bz

Member

Manishearth commented Feb 2, 2017

@bors-servo r=emilio,bz

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Feb 2, 2017

Contributor

📌 Commit 6e2cbe6 has been approved by emilio,bz

Contributor

bors-servo commented Feb 2, 2017

📌 Commit 6e2cbe6 has been approved by emilio,bz

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Feb 4, 2017

Contributor

☔️ The latest upstream changes (presumably #15363) made this pull request unmergeable. Please resolve the merge conflicts.

Contributor

bors-servo commented Feb 4, 2017

☔️ The latest upstream changes (presumably #15363) made this pull request unmergeable. Please resolve the merge conflicts.

@Manishearth

This comment has been minimized.

Show comment
Hide comment
@Manishearth

Manishearth Feb 4, 2017

Member

@bors-servo r=emilio,bz

Member

Manishearth commented Feb 4, 2017

@bors-servo r=emilio,bz

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Feb 4, 2017

Contributor

📌 Commit 718d6fe has been approved by emilio,bz

Contributor

bors-servo commented Feb 4, 2017

📌 Commit 718d6fe has been approved by emilio,bz

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Feb 4, 2017

Contributor

⌛️ Testing commit 718d6fe with merge de435f2...

Contributor

bors-servo commented Feb 4, 2017

⌛️ Testing commit 718d6fe with merge de435f2...

bors-servo added a commit that referenced this pull request Feb 4, 2017

Auto merge of #15331 - Manishearth:stylo-presattr, r=emilio,bz
Basic handling framework for presentation attributes in Stylo, with handling for font-size and color

https://bugzilla.mozilla.org/show_bug.cgi?id=1330041

r=emilio,bz

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15331)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Feb 4, 2017

Contributor

💔 Test failed - mac-dev-unit

Contributor

bors-servo commented Feb 4, 2017

💔 Test failed - mac-dev-unit

Basic handling framework for presentation attributes in Stylo, with h…
…andling for font-size and color

This introduces a basic framework for servo's style system to be able
to query the style of presentation attributes which it can then insert
into the cascade. It uses that framework to implement the size and
color attributes on <font>.

There are a number of improvements that can be done on top of this:

 - Implement all other properties
 - Abstractify the ruledata parameter of the mappers using templates or virtual dispatch so that it can be a Servo decl block instead
 - Implement aforementiond abstraction over Servo decl blocks (this obsoletes the code in the first item above, so it might just be better to skip that and directly do this)
 - Replace uses of nsHTMLStyleSheet with an abstract base class containing common elements between Servo and Gecko

I'd prefer for these to be done in separate steps.
@Manishearth

This comment has been minimized.

Show comment
Hide comment
@Manishearth

Manishearth Feb 4, 2017

Member

@bors-servo r=emilio,bz

ugh nocalclength broke everything :p

Member

Manishearth commented Feb 4, 2017

@bors-servo r=emilio,bz

ugh nocalclength broke everything :p

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Feb 4, 2017

Contributor

📌 Commit 34ba00e has been approved by emilio,bz

Contributor

bors-servo commented Feb 4, 2017

📌 Commit 34ba00e has been approved by emilio,bz

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Feb 4, 2017

Contributor

⌛️ Testing commit 34ba00e with merge 57fb07e...

Contributor

bors-servo commented Feb 4, 2017

⌛️ Testing commit 34ba00e with merge 57fb07e...

bors-servo added a commit that referenced this pull request Feb 4, 2017

Auto merge of #15331 - Manishearth:stylo-presattr, r=emilio,bz
Basic handling framework for presentation attributes in Stylo, with handling for font-size and color

https://bugzilla.mozilla.org/show_bug.cgi?id=1330041

r=emilio,bz

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15331)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Feb 4, 2017

Contributor

💔 Test failed - mac-rel-wpt1

Contributor

bors-servo commented Feb 4, 2017

💔 Test failed - mac-rel-wpt1

@Manishearth

This comment has been minimized.

Show comment
Hide comment
@Manishearth
Member

Manishearth commented Feb 4, 2017

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Feb 4, 2017

Contributor

⚡️ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev are reusable. Rebuilding only mac-rel-wpt1...

Contributor

bors-servo commented Feb 4, 2017

⚡️ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev are reusable. Rebuilding only mac-rel-wpt1...

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Feb 4, 2017

Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: emilio,bz
Pushing 57fb07e to master...

Contributor

bors-servo commented Feb 4, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: emilio,bz
Pushing 57fb07e to master...

@bors-servo bors-servo merged commit 34ba00e into servo:master Feb 4, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@Manishearth Manishearth deleted the Manishearth:stylo-presattr branch Feb 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment