Basic handling framework for presentation attributes in Stylo, with handling for font-size and color #15331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up! This PR modifies the following files:
|
|
|
Manishearth
force-pushed
the
stylo-presattr
branch
from
7b662ab
to
fdcb1fd
Compare
|
@bors-servo are you still there? |
|
@bors-servo ping |
|
@bors-servo delegate=Manishearth |
|
✌️ @Manishearth can now approve this pull request |
|
@bors-servo are you still there? |
1 similar comment
|
@bors-servo are you still there? |
|
@bors-servo r=emilio,bz |
|
📌 Commit fdcb1fd has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Feb 2, 2017
Basic handling framework for presentation attributes in Stylo, with handling for font-size and color https://bugzilla.mozilla.org/show_bug.cgi?id=1330041 r=emilio,bz <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15331) <!-- Reviewable:end -->
|
💔 Test failed - mac-dev-unit |
highfive
added
S-tests-failed
|
@bors-servo are you still there? |
1 similar comment
|
@bors-servo are you still there? |
|
🍰 There you are
|
Manishearth
force-pushed
the
stylo-presattr
branch
from
fdcb1fd
to
6e2cbe6
Compare
highfive
added
S-awaiting-review
|
@bors-servo r=emilio,bz |
|
📌 Commit 6e2cbe6 has been approved by |
Manishearth
force-pushed
the
stylo-presattr
branch
from
ca5c31c
to
718d6fe
Compare
|
@bors-servo r=emilio,bz |
|
📌 Commit 718d6fe has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Feb 4, 2017
Basic handling framework for presentation attributes in Stylo, with handling for font-size and color https://bugzilla.mozilla.org/show_bug.cgi?id=1330041 r=emilio,bz <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15331) <!-- Reviewable:end -->
|
💔 Test failed - mac-dev-unit |
highfive
added
S-tests-failed
…andling for font-size and color This introduces a basic framework for servo's style system to be able to query the style of presentation attributes which it can then insert into the cascade. It uses that framework to implement the size and color attributes on <font>. There are a number of improvements that can be done on top of this: - Implement all other properties - Abstractify the ruledata parameter of the mappers using templates or virtual dispatch so that it can be a Servo decl block instead - Implement aforementiond abstraction over Servo decl blocks (this obsoletes the code in the first item above, so it might just be better to skip that and directly do this) - Replace uses of nsHTMLStyleSheet with an abstract base class containing common elements between Servo and Gecko I'd prefer for these to be done in separate steps.
Manishearth
force-pushed
the
stylo-presattr
branch
from
718d6fe
to
34ba00e
Compare
highfive
added
S-awaiting-review
|
@bors-servo r=emilio,bz ugh nocalclength broke everything :p |
|
📌 Commit 34ba00e has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Feb 4, 2017
Basic handling framework for presentation attributes in Stylo, with handling for font-size and color https://bugzilla.mozilla.org/show_bug.cgi?id=1330041 r=emilio,bz <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15331) <!-- Reviewable:end -->
|
💔 Test failed - mac-rel-wpt1 |
highfive
added
S-tests-failed
|
⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev are reusable. Rebuilding only mac-rel-wpt1... |
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.mozilla.org/show_bug.cgi?id=1330041
r=emilio,bz
This change is