Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rustc-serialize from cookie and url #15717

Merged
merged 2 commits into from Feb 24, 2017

Conversation

Projects
None yet
4 participants
@nox
Copy link
Member

commented Feb 24, 2017

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Feb 24, 2017

Heads up! This PR modifies the following files:

  • @asajeffrey: components/webdriver_server/Cargo.toml
  • @jgraham: components/webdriver_server/Cargo.toml
  • @fitzgen: components/script/Cargo.toml, components/script_traits/Cargo.toml, components/script_traits/Cargo.toml
  • @KiChjang: components/net/Cargo.toml, components/script/Cargo.toml, components/net_traits/Cargo.toml, components/net_traits/Cargo.toml, components/script_traits/Cargo.toml, components/script_traits/Cargo.toml
@highfive

This comment has been minimized.

Copy link

commented Feb 24, 2017

warning Warning warning

  • These commits modify net and script code, but no tests are modified. Please consider adding a test!

@nox nox changed the title Remove rustc-serialize from cookie Remove rustc-serialize from cookie and url Feb 24, 2017

@asajeffrey

This comment has been minimized.

Copy link
Member

commented Feb 24, 2017

LGTM. Squash at your own discretion then r=me.

@nox

This comment has been minimized.

Copy link
Member Author

commented Feb 24, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Feb 24, 2017

📌 Commit 2efa509 has been approved by asajeffrey

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Feb 24, 2017

⌛️ Testing commit 2efa509 with merge 0e33756...

bors-servo added a commit that referenced this pull request Feb 24, 2017

Auto merge of #15717 - nox:cookie, r=asajeffrey
Remove rustc-serialize from cookie and url

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15717)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Feb 24, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: asajeffrey
Pushing 0e33756 to master...

@bors-servo bors-servo merged commit 2efa509 into servo:master Feb 24, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.