Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rustc-serialize from cookie and url #15717

Merged
merged 2 commits into from Feb 24, 2017
Merged

Remove rustc-serialize from cookie and url #15717

merged 2 commits into from Feb 24, 2017

Conversation

nox
Copy link
Contributor

@nox nox commented Feb 24, 2017 •
edited by larsbergstrom

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @asajeffrey: components/webdriver_server/Cargo.toml
  • @jgraham: components/webdriver_server/Cargo.toml
  • @fitzgen: components/script/Cargo.toml, components/script_traits/Cargo.toml, components/script_traits/Cargo.toml
  • @KiChjang: components/net/Cargo.toml, components/script/Cargo.toml, components/net_traits/Cargo.toml, components/net_traits/Cargo.toml, components/script_traits/Cargo.toml, components/script_traits/Cargo.toml

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Feb 24, 2017
@highfive
Copy link

warning Warning warning

  • These commits modify net and script code, but no tests are modified. Please consider adding a test!

@nox nox changed the title Remove rustc-serialize from cookie Remove rustc-serialize from cookie and url Feb 24, 2017
@asajeffrey
Copy link
Member

LGTM. Squash at your own discretion then r=me.

@nox
Copy link
Contributor Author

nox commented Feb 24, 2017 via email

@bors-servo
Copy link
Contributor

📌 Commit 2efa509 has been approved by asajeffrey

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Feb 24, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 2efa509 with merge 0e33756...

bors-servo pushed a commit that referenced this pull request Feb 24, 2017
Auto merge of #15717 - nox:cookie, r=asajeffrey
0e33756 
Remove rustc-serialize from cookie and url

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15717)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: asajeffrey
Pushing 0e33756 to master...

@bors-servo bors-servo merged commit 2efa509 into servo:master Feb 24, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Feb 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@asajeffrey asajeffrey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nox @highfive @asajeffrey @bors-servo