stylo: Fix adjustment of the display property to save mOriginalDisplay properly. #15742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up! This PR modifies the following files:
|
|
|
highfive
added
the
S-awaiting-review
|
Or, also r? @bzbarsky, if he wants to, I guess ;) |
bzbarsky
reviewed
Feb 27, 2017
| /// which we want to keep. | ||
| pub fn set_adjusted_display(&mut self, v: longhands::display::computed_value::T) { | ||
| use properties::longhands::display::computed_value::T as Keyword; | ||
| let result = match v { |
There was a problem hiding this comment.
Worth factoring this shared code out of set_display and here?
|
@bors-servo r+ |
|
@bzbarsky: 🔑 Insufficient privileges: Not in reviewers |
|
@bors-servo r=bzbarsky |
|
📌 Commit f695789 has been approved by |
highfive
added
S-awaiting-merge
|
⌛ Testing commit f695789 with merge cecbc33... |
bors-servo
pushed a commit
that referenced
this pull request
Feb 27, 2017
stylo: Fix adjustment of the display property to save mOriginalDisplay properly. r? @heycam <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15742) <!-- Reviewable:end -->
emilio
added a commit
to servo/saltfs
that referenced
this pull request
Feb 27, 2017
He's done a bunch of reviews (servo/servo#15742, servo/servo#15691 and a bunch of others unofficially), both as part of stylo as part of the DOM integration. I think he's trusted enough to have review powers.
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @heycam
This change is