Set each control points when converting specified keyworded timing fu… #16233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewed by @emilio |
emilio
approved these changes
Apr 3, 2017
| self.mType = nsTimingFunction_Type::CubicBezier; | ||
| fn set_as_bezier(&mut self, | ||
| function_type: nsTimingFunction_Type, | ||
| p1: Point2D<f32>, p2: Point2D<f32>) { |
|
@bors-servo delegate+ |
|
✌️ @hiikezoe can now approve this pull request |
…nction to nsTimingFunction. Gecko's timing function (nsTimingFunction) needs to be specified each control points if timing function can be represented as cubic-bezier function. To avoid scattering control points values (e.g. 0.25, 0.1, ...) we convert specified value to computed value and then use control points values of the computed value.
hiikezoe
force-pushed
the
timing-function-fix
branch
from
d4690f2
to
f361992
Compare
|
@bors-servo r=emilio |
|
📌 Commit f361992 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Apr 3, 2017
Set each control points when converting specified keyworded timing fu… …nction to nsTimingFunction. Gecko's timing function (nsTimingFunction) needs to be specified each control points if timing function can be represented as cubic-bezier function. To avoid scattering control points values (e.g. 0.25, 0.1, ...) we convert specified value to computed value and then use control points values of the computed value. <!-- Please describe your changes on the following line: --> This is a PR of https://bugzilla.mozilla.org/show_bug.cgi?id=1352891 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because it's for stylo. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16233) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nction to nsTimingFunction.
Gecko's timing function (nsTimingFunction) needs to be specified
each control points if timing function can be represented as cubic-bezier
function. To avoid scattering control points values (e.g. 0.25, 0.1, ...)
we convert specified value to computed value and then use control points
values of the computed value.
This is a PR of https://bugzilla.mozilla.org/show_bug.cgi?id=1352891
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is