Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: Correctly serialize CSS Custom Property names. #16691

Merged
merged 1 commit into from May 2, 2017
Merged

style: Correctly serialize CSS Custom Property names. #16691

merged 1 commit into from May 2, 2017

Conversation

heycam
Copy link
Contributor

@heycam heycam commented May 2, 2017 •
edited by larsbergstrom

From https://bugzilla.mozilla.org/show_bug.cgi?id=1361303, and reviewed by Xidorn over there.

This change is Reviewable

@highfive
Copy link

highfive commented May 2, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/properties.mako.rs
  • @emilio: ports/geckolib/glue.rs, components/style/properties/properties.mako.rs

@highfive
Copy link

highfive commented May 2, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label May 2, 2017
@heycam
Copy link
Contributor Author

heycam commented May 2, 2017

@bors-servo r=xidorn

@bors-servo
Copy link
Contributor

📌 Commit 53eb1bb has been approved by xidorn

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels May 2, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 53eb1bb with merge 997a3e8...

bors-servo pushed a commit that referenced this pull request May 2, 2017
Auto merge of #16691 - heycam:custom-prop-name, r=xidorn
997a3e8 
style: Correctly serialize CSS Custom Property names.

From https://bugzilla.mozilla.org/show_bug.cgi?id=1361303, and reviewed by Xidorn over there.
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: xidorn
Pushing 997a3e8 to master...

@bors-servo bors-servo merged commit 53eb1bb into servo:master May 2, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label May 2, 2017
@heycam heycam mentioned this pull request May 3, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wafflespeanut wafflespeanut

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@heycam @highfive @bors-servo @wafflespeanut