Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1366427: Make backdrop not inherit from the parent element. r=heycam #16981

Merged
merged 1 commit into from
May 23, 2017

Conversation

emilio
Copy link
Member

@emilio emilio commented May 21, 2017

This change is Reviewable

MozReview-Commit-ID: EnnmvDsgbdx
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
@highfive
Copy link

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko/pseudo_element.rs, components/style/stylist.rs

@highfive
Copy link

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label May 21, 2017
@emilio
Copy link
Member Author

emilio commented May 21, 2017

@bors-servo r=heycam

@bors-servo
Copy link
Contributor

📌 Commit 71dbc6c has been approved by heycam

@highfive highfive assigned heycam and unassigned nox May 21, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels May 21, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 71dbc6c with merge 17069f4...

bors-servo pushed a commit that referenced this pull request May 23, 2017
Bug 1366427: Make backdrop not inherit from the parent element. r=heycam

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16981)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: heycam
Pushing 17069f4 to master...

@bors-servo bors-servo merged commit 71dbc6c into servo:master May 23, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label May 23, 2017
bors-servo pushed a commit that referenced this pull request May 23, 2017
stylo: Fixup an embarrassing typo that has turned everything orange.

I messed up when turning the conditions the other way around in #16981.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17005)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this pull request May 23, 2017
stylo: Fixup an embarrassing typo that has turned everything orange.

I messed up when turning the conditions the other way around in #16981.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17005)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants