-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1366427: Make backdrop not inherit from the parent element. r=heycam #16981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MozReview-Commit-ID: EnnmvDsgbdx Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
Heads up! This PR modifies the following files:
|
highfive
added
the
S-awaiting-review
There is new code that needs to be reviewed.
label
May 21, 2017
@bors-servo r=heycam |
📌 Commit 71dbc6c has been approved by |
highfive
added
S-awaiting-merge
The PR is in the process of compiling and running tests on the automated CI.
and removed
S-awaiting-review
There is new code that needs to be reviewed.
labels
May 21, 2017
bors-servo
pushed a commit
that referenced
this pull request
May 23, 2017
Bug 1366427: Make backdrop not inherit from the parent element. r=heycam <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16981) <!-- Reviewable:end -->
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
The PR is in the process of compiling and running tests on the automated CI.
label
May 23, 2017
bors-servo
pushed a commit
that referenced
this pull request
May 23, 2017
stylo: Fixup an embarrassing typo that has turned everything orange. I messed up when turning the conditions the other way around in #16981. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17005) <!-- Reviewable:end -->
bors-servo
pushed a commit
that referenced
this pull request
May 23, 2017
stylo: Fixup an embarrassing typo that has turned everything orange. I messed up when turning the conditions the other way around in #16981. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17005) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is