Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue to slim down the code for CSS properties #17122

Merged
merged 4 commits into from Jun 2, 2017

Conversation

@nox
Copy link
Member

commented Jun 1, 2017

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Jun 1, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/values/generics/text.rs, components/style/values/computed/text.rs, components/style/values/computed/mod.rs, components/style/properties/longhand/outline.mako.rs, components/style/values/generics/border.rs and 13 more
  • @KiChjang: components/script/dom/element.rs
  • @fitzgen: components/script/dom/element.rs
  • @emilio: components/style/values/generics/text.rs, ports/geckolib/glue.rs, components/style/values/computed/text.rs, components/style/values/computed/mod.rs, components/style/properties/longhand/outline.mako.rs and 14 more
@nox

This comment has been minimized.

@emilio
emilio approved these changes Jun 1, 2017
Copy link
Member

left a comment

r=me

/// A computed value for the `letter-spacing` property.
pub type LetterSpacing = Spacing<Length>;

/// A specified value for the `letter-spacing` property.

This comment has been minimized.

Copy link
@emilio

emilio Jun 1, 2017

Member

A computed value for the word-spacing property, right?

@wafflespeanut

This comment has been minimized.

Copy link
Member

commented Jun 1, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 1, 2017

📌 Commit fb6bc02 has been approved by wafflespeanut

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 1, 2017

⌛️ Testing commit fb6bc02 with merge 336d90b...

bors-servo added a commit that referenced this pull request Jun 1, 2017
Auto merge of #17122 - servo:derive-all-the-things, r=wafflespeanut
Continue to slim down the code for CSS properties

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17122)
<!-- Reviewable:end -->
@wafflespeanut

This comment has been minimized.

Copy link
Member

commented Jun 1, 2017

@bors-servo r-

Oh, didn't see that comment.

@nox nox force-pushed the derive-all-the-things branch from fb6bc02 to 2adb5fe Jun 1, 2017

@nox

This comment has been minimized.

Copy link
Member Author

commented Jun 1, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 1, 2017

📌 Commit 2adb5fe has been approved by nox

@highfive highfive assigned nox and unassigned wafflespeanut Jun 1, 2017

@nox

This comment has been minimized.

Copy link
Member Author

commented Jun 1, 2017

@bors-servo r=emilio

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 1, 2017

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: #17104
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 1, 2017

📌 Commit 2adb5fe has been approved by emilio

@highfive highfive assigned emilio and unassigned nox Jun 1, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 1, 2017

⌛️ Testing commit 2adb5fe with merge 08c251f...

bors-servo added a commit that referenced this pull request Jun 1, 2017
Auto merge of #17122 - servo:derive-all-the-things, r=emilio
Continue to slim down the code for CSS properties

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17122)
<!-- Reviewable:end -->

@nox nox force-pushed the derive-all-the-things branch from 697d000 to c4e8ee1 Jun 2, 2017

@nox

This comment has been minimized.

Copy link
Member Author

commented Jun 2, 2017

@bors-servo r=emilio

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 2, 2017

📌 Commit c4e8ee1 has been approved by emilio

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 2, 2017

⌛️ Testing commit c4e8ee1 with merge ac546ae...

bors-servo added a commit that referenced this pull request Jun 2, 2017
Auto merge of #17122 - servo:derive-all-the-things, r=emilio
Continue to slim down the code for CSS properties

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17122)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 2, 2017

💔 Test failed - linux-rel-wpt

@nox

This comment has been minimized.

Copy link
Member Author

commented Jun 2, 2017

  ▶ Unexpected subtest result in /cssom/serialize-values.html:
  └ PASS [expected FAIL] outline-width: thin

  ▶ Unexpected subtest result in /cssom/serialize-values.html:
  └ PASS [expected FAIL] outline-width: medium

  ▶ Unexpected subtest result in /cssom/serialize-values.html:
  └ PASS [expected FAIL] outline-width: thick

Nice.

@nox nox force-pushed the derive-all-the-things branch from c4e8ee1 to e58f541 Jun 2, 2017

@nox

This comment has been minimized.

Copy link
Member Author

commented Jun 2, 2017

@bors-servo r=emilio

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 2, 2017

📌 Commit e58f541 has been approved by emilio

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 2, 2017

⌛️ Testing commit e58f541 with merge 028908e...

bors-servo added a commit that referenced this pull request Jun 2, 2017
Auto merge of #17122 - servo:derive-all-the-things, r=emilio
Continue to slim down the code for CSS properties

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17122)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 2, 2017

@bors-servo bors-servo merged commit e58f541 into master Jun 2, 2017

3 of 4 checks passed

dependency-ci Failed dependency checks
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@SimonSapin SimonSapin deleted the derive-all-the-things branch Jun 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.