stylo: remove bogus optimization check in replace_rules() for visited styles. #17889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up! This PR modifies the following files:
|
highfive
added
the
S-awaiting-review
|
|
|
@bors-servo r=hiro |
|
📌 Commit 372b2a1 has been approved by |
highfive
added
S-awaiting-merge
chenpighead
changed the title
… styles. We skipped updating the rule nodes for visited rules during animation-only restyle. However, this causes isseus that visited style overrides animation styles on visited element. So, it turns out that we should update the visited rules even during animation-only restyle. Gecko bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1381235
chenpighead
force-pushed
the
fix-transition-visited
branch
from
372b2a1
to
000547b
Compare
highfive
added
S-awaiting-review
|
@bors-servo r=hiro |
|
📌 Commit 000547b has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Jul 27, 2017
stylo: remove bogus optimization check in replace_rules() for visited styles. We skipped updating the rule nodes for visited rules during animation-only restyle. However, this causes isseus that visited style overrides animation styles on visited element. So, it turns out that we should update the visited rules even during animation-only restyle. Gecko bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1381235 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17889) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We skipped updating the rule nodes for visited rules during animation-only restyle.
However, this causes isseus that visited style overrides animation styles on visited element.
So, it turns out that we should update the visited rules even during animation-only restyle.
Gecko bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1381235
This change is