Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stylo: remove bogus optimization check in replace_rules() for visited styles. #17889

Merged
merged 1 commit into from Jul 27, 2017

Conversation

@chenpighead
Copy link
Contributor

commented Jul 27, 2017

We skipped updating the rule nodes for visited rules during animation-only restyle.
However, this causes isseus that visited style overrides animation styles on visited element.
So, it turns out that we should update the visited rules even during animation-only restyle.

Gecko bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1381235


This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Jul 27, 2017

Heads up! This PR modifies the following files:

@highfive

This comment has been minimized.

Copy link

commented Jul 27, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@chenpighead

This comment has been minimized.

Copy link
Contributor Author

commented Jul 27, 2017

@bors-servo r=hiro

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 27, 2017

📌 Commit 372b2a1 has been approved by hiro

@chenpighead chenpighead changed the title stylo: fix the optimization check in replace_rules() for visited styles. stylo: remove bogus optimization check in replace_rules() for visited styles. Jul 27, 2017

stylo: remove bogus optimization check in replace_rules() for visited…
… styles.

We skipped updating the rule nodes for visited rules during animation-only restyle.
However, this causes isseus that visited style overrides animation styles on visited element.
So, it turns out that we should update the visited rules even during animation-only restyle.

Gecko bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1381235

@chenpighead chenpighead force-pushed the chenpighead:fix-transition-visited branch from 372b2a1 to 000547b Jul 27, 2017

@chenpighead

This comment has been minimized.

Copy link
Contributor Author

commented Jul 27, 2017

@bors-servo r=hiro

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 27, 2017

📌 Commit 000547b has been approved by hiro

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 27, 2017

⌛️ Testing commit 000547b with merge d429561...

bors-servo added a commit that referenced this pull request Jul 27, 2017
Auto merge of #17889 - chenpighead:fix-transition-visited, r=hiro
stylo: remove bogus optimization check in replace_rules() for visited styles.

We skipped updating the rule nodes for visited rules during animation-only restyle.
However, this causes isseus that visited style overrides animation styles on visited element.
So, it turns out that we should update the visited rules even during animation-only restyle.

Gecko bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1381235

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17889)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 27, 2017

@bors-servo bors-servo merged commit 000547b into servo:master Jul 27, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.