style: Multiple calc serialization fixes. #18131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up! This PR modifies the following files:
|
highfive
added
the
S-awaiting-review
|
r? @canaltinova or @nox |
canova
approved these changes
Aug 17, 2017
| // | ||
| // calc(10px + -5%) | ||
| // | ||
| // Need to update and run through try. |
There was a problem hiding this comment.
I think we should change the computed value as well and test with a try run while we are at it. Is there a reason to prevents to do that right now?
There was a problem hiding this comment.
(And I'd need to find a good revision, etc...)
I'll push a try run and if this hasn't landed tomorrow morning I'll just push it.
There was a problem hiding this comment.
Well, I think this PR can wait, since it doesn't block anything, but either way is ok I guess.
|
@bors-servo r=canaltinova
|
|
📌 Commit 52d6838 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Aug 18, 2017
style: Multiple calc serialization fixes. This puts us in line with the spec as written, except for caveat in w3c/csswg-drafts#1731. Need to fix computed calc() too, I'm less confident that we won't need to change test expectations. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18131) <!-- Reviewable:end -->
|
💔 Test failed - linux-rel-wpt |
highfive
added
S-tests-failed
emilio
force-pushed
the
calc-serialization
branch
from
52d6838
to
c3fc8ef
Compare
highfive
added
S-awaiting-review
emilio
force-pushed
the
calc-serialization
branch
from
c3fc8ef
to
02f09e1
Compare
|
@bors-servo r=canaltinova |
|
📌 Commit 02f09e1 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Aug 18, 2017
style: Multiple calc serialization fixes. This puts us in line with the spec as written, except for caveat in w3c/csswg-drafts#1731. Need to fix computed calc() too, I'm less confident that we won't need to change test expectations. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18131) <!-- Reviewable:end -->
|
💔 Test failed - linux-dev |
highfive
added
S-tests-failed
emilio
force-pushed
the
calc-serialization
branch
from
02f09e1
to
6df597b
Compare
highfive
added
S-awaiting-review
|
@bors-servo r=canaltinova p=1
|
|
📌 Commit 6df597b has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Aug 18, 2017
style: Multiple calc serialization fixes. This puts us in line with the spec as written, except for caveat in w3c/csswg-drafts#1731. Need to fix computed calc() too, I'm less confident that we won't need to change test expectations. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18131) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Aug 18, 2017
…#18131. r=bholley calc() serialization in stylo changed to align to the spec more closely (modulo percentage order). See the linked issue. MozReview-Commit-ID: GyzZvdumMSe
bholley
pushed a commit
to bholley/gecko
that referenced
this pull request
Aug 19, 2017
…#18131. r=bholley calc() serialization in stylo changed to align to the spec more closely (modulo percentage order). See the linked issue. MozReview-Commit-ID: GyzZvdumMSe
aethanyc
pushed a commit
to aethanyc/gecko-dev
that referenced
this pull request
Aug 21, 2017
…#18131. r=bholley calc() serialization in stylo changed to align to the spec more closely (modulo percentage order). See the linked issue. MozReview-Commit-ID: GyzZvdumMSe
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 1, 2019
…#18131. r=bholley calc() serialization in stylo changed to align to the spec more closely (modulo percentage order). See the linked issue. MozReview-Commit-ID: GyzZvdumMSe UltraBlame original commit: 7b4da6a65ea1dcc665c9aec416223ea6e70192af
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 1, 2019
…#18131. r=bholley calc() serialization in stylo changed to align to the spec more closely (modulo percentage order). See the linked issue. MozReview-Commit-ID: GyzZvdumMSe UltraBlame original commit: 7b4da6a65ea1dcc665c9aec416223ea6e70192af
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 1, 2019
…#18131. r=bholley calc() serialization in stylo changed to align to the spec more closely (modulo percentage order). See the linked issue. MozReview-Commit-ID: GyzZvdumMSe UltraBlame original commit: 7b4da6a65ea1dcc665c9aec416223ea6e70192af
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This puts us in line with the spec as written, except for caveat in w3c/csswg-drafts#1731.
Need to fix computed calc() too, I'm less confident that we won't need to change test expectations.
This change is