style: Remove Stylist::is_device_dirty. #18143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up! This PR modifies the following files:
|
|
|
highfive
added
the
S-awaiting-review
|
r? @SimonSapin |
emilio
force-pushed
the
stylist-stylesheets
branch
from
f9ef170
to
dd672a2
Compare
|
@bors-servo try |
bors-servo
pushed a commit
that referenced
this pull request
Aug 18, 2017
style: Remove Stylist::is_device_dirty. More progress on unifying how Gecko and Servo track stylist dirtiness. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18143) <!-- Reviewable:end -->
|
💔 Test failed - mac-rel-wpt4 |
|
|
Yup, looks like I got stuff to debug :) |
emilio
force-pushed
the
stylist-stylesheets
branch
from
dd672a2
to
8e36658
Compare
|
@bors-servo try |
|
⌛ Trying commit 8e36658 with merge b9bc0d2e7b5c957e11e9ecc6ab4ffa581a06627b... |
|
💔 Test failed - linux-rel-wpt |
|
@bors-servo retry |
bors-servo
pushed a commit
that referenced
this pull request
Aug 19, 2017
style: Remove Stylist::is_device_dirty. More progress on unifying how Gecko and Servo track stylist dirtiness. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18143) <!-- Reviewable:end -->
|
@bors-servo try |
bors-servo
pushed a commit
that referenced
this pull request
Aug 19, 2017
style: Remove Stylist::is_device_dirty. More progress on unifying how Gecko and Servo track stylist dirtiness. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18143) <!-- Reviewable:end -->
|
💔 Test failed - arm32 |
|
@bors-servo retry p=10
|
bors-servo
pushed a commit
that referenced
this pull request
Aug 21, 2017
style: Remove Stylist::is_device_dirty. More progress on unifying how Gecko and Servo track stylist dirtiness. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18143) <!-- Reviewable:end -->
bors-servo
pushed a commit
that referenced
this pull request
Aug 21, 2017
style: Move the StyleSheetSet into the Stylist. This will allow tracking whether there have been only additions to the stylesheet set, and in that case don't destroy and completely rebuild the invalidation map. This is on top of #18143. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18170) <!-- Reviewable:end -->
|
💔 Test failed - mac-rel-wpt4 |
|
It's back again: |
More progress on unifying how Gecko and Servo track stylist dirtiness.
…e don't start it. Otherwise we may get to the end of it directly, which is far from what we want.
emilio
force-pushed
the
stylist-stylesheets
branch
from
50acb3b
to
293274f
Compare
|
sigh |
highfive
added
S-awaiting-review
|
@bors-servo try |
bors-servo
pushed a commit
that referenced
this pull request
Aug 21, 2017
style: Remove Stylist::is_device_dirty. More progress on unifying how Gecko and Servo track stylist dirtiness. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18143) <!-- Reviewable:end -->
|
@bors-servo r=SimonSapin
|
|
📌 Commit 293274f has been approved by |
highfive
added
S-awaiting-merge
|
⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only mac-rel-wpt2, mac-rel-wpt3... |
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
5 tasks
bors-servo
pushed a commit
that referenced
this pull request
Aug 22, 2017
style: Move the StyleSheetSet into the Stylist. This will allow tracking whether there have been only additions to the stylesheet set, and in that case don't destroy and completely rebuild the invalidation map. This is on top of #18143. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18170) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More progress on unifying how Gecko and Servo track stylist dirtiness.
This change is