Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Devirtualize CSS error reporting. #18209

Merged
merged 1 commit into from Aug 24, 2017
Merged

Devirtualize CSS error reporting. #18209

merged 1 commit into from Aug 24, 2017

Conversation

jdm
Copy link
Member

@jdm jdm commented Aug 24, 2017 •
edited by SimonSapin

This removes a trait object from the path of reporting a CSS error.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • There are tests for these changes

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @bholley: components/style/stylesheets/font_feature_values_rule.rs, components/style/stylesheets/viewport_rule.rs, components/style/counter_style/mod.rs, components/style/parser.rs, components/style/stylesheets/keyframes_rule.rs and 8 more
  • @canaltinova: components/style/stylesheets/font_feature_values_rule.rs, components/style/stylesheets/viewport_rule.rs, components/style/counter_style/mod.rs, components/style/parser.rs, components/style/stylesheets/keyframes_rule.rs and 8 more
  • @KiChjang: components/script/dom/htmllinkelement.rs, components/script/dom/cssmediarule.rs, components/script/dom/medialist.rs, components/script/dom/htmlstyleelement.rs, components/script/dom/css.rs and 2 more
  • @fitzgen: components/script/dom/htmllinkelement.rs, components/script/dom/cssmediarule.rs, components/script/dom/medialist.rs, components/script/dom/htmlstyleelement.rs, components/script/dom/css.rs and 2 more
  • @emilio: components/style/stylesheets/font_feature_values_rule.rs, components/style/stylesheets/viewport_rule.rs, components/style/counter_style/mod.rs, components/style/parser.rs, components/style/stylesheets/keyframes_rule.rs and 9 more

@highfive
Copy link

warning Warning warning

  • These commits modify style and script code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Aug 24, 2017
@jdm jdm force-pushed the devirtualize branch 2 times, most recently from d7a4909 to 5980d49 Compare August 24, 2017 17:28
@mbrubeck mbrubeck assigned mbrubeck and unassigned KiChjang Aug 24, 2017
mbrubeck
mbrubeck approved these changes Aug 24, 2017
View reviewed changes
Copy link
Contributor

@mbrubeck mbrubeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with a couple of tidy errors fixed:

./tests/unit/style/properties/mod.rs:13: Line is longer than 120 characters

./tests/unit/style/properties/mod.rs:19: Line is longer than 120 characters

@jdm
Copy link
Member Author

jdm commented Aug 24, 2017

@bors-servo: r=mbrubeck

@bors-servo
Copy link
Contributor

📌 Commit 1297c0f has been approved by mbrubeck

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Aug 24, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 1297c0f with merge d4ddec8...

bors-servo pushed a commit that referenced this pull request Aug 24, 2017
Auto merge of #18209 - jdm:devirtualize, r=mbrubeck
d4ddec8 
Devirtualize CSS error reporting.

This removes a trait object from the path of reporting a CSS error.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18209)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: mbrubeck
Pushing d4ddec8 to master...

@bors-servo bors-servo merged commit 1297c0f into servo:master Aug 24, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Aug 24, 2017
@bors-servo bors-servo mentioned this pull request Aug 24, 2017
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrubeck mbrubeck mbrubeck approved these changes

Assignees

@mbrubeck mbrubeck

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jdm @highfive @bors-servo @mbrubeck @KiChjang