Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stylo: followup fixes for restyle roots #18246

Merged
merged 1 commit into from
Aug 26, 2017

Conversation

bholley
Copy link
Contributor

@bholley bholley commented Aug 25, 2017

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @canaltinova: components/style/gecko/wrapper.rs, components/style/dom.rs, components/style/traversal.rs
  • @emilio: components/style/gecko/wrapper.rs, components/style/dom.rs, components/style/traversal.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Aug 25, 2017
@highfive
Copy link

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!

@bholley
Copy link
Contributor Author

bholley commented Aug 25, 2017

@bors-servo r=emilio p=1

@bors-servo
Copy link
Contributor

📌 Commit d54c49d has been approved by emilio

@highfive highfive assigned emilio and unassigned Manishearth Aug 25, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Aug 25, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit d54c49d with merge fa78927236a8f81ed06e2552f5b38ab1c868a53c...

@bors-servo
Copy link
Contributor

💔 Test failed - mac-dev-unit

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Aug 26, 2017
@bholley
Copy link
Contributor Author

bholley commented Aug 26, 2017

@bors-servo retry

@bors-servo
Copy link
Contributor

⌛ Testing commit d54c49d with merge 03a6ec8...

bors-servo pushed a commit that referenced this pull request Aug 26, 2017
stylo: followup fixes for restyle roots

https://bugzilla.mozilla.org/show_bug.cgi?id=1392863

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18246)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Aug 26, 2017
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-css

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Aug 26, 2017
@bholley
Copy link
Contributor Author

bholley commented Aug 26, 2017

@bors-servo retry

@bors-servo
Copy link
Contributor

⌛ Testing commit d54c49d with merge f10d4c1...

bors-servo pushed a commit that referenced this pull request Aug 26, 2017
stylo: followup fixes for restyle roots

https://bugzilla.mozilla.org/show_bug.cgi?id=1392863

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18246)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Aug 26, 2017
@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-wpt1

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Aug 26, 2017
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Aug 26, 2017
@bholley
Copy link
Contributor Author

bholley commented Aug 26, 2017

@bors-servo r=emilio

@bors-servo
Copy link
Contributor

📌 Commit 994074f has been approved by emilio

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Aug 26, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 994074f with merge 1fd0edf...

bors-servo pushed a commit that referenced this pull request Aug 26, 2017
stylo: followup fixes for restyle roots

https://bugzilla.mozilla.org/show_bug.cgi?id=1392863

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18246)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing 1fd0edf to master...

@bors-servo bors-servo merged commit 994074f into servo:master Aug 26, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Aug 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants