Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use absolute paths in the event handlers macros #18314

Merged
merged 1 commit into from Sep 1, 2017
Merged

Use absolute paths in the event handlers macros #18314

merged 1 commit into from Sep 1, 2017

Conversation

nox
Copy link
Contributor

@nox nox commented Aug 30, 2017 •
edited by SimonSapin

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/permissionstatus.rs, components/script/dom/filereader.rs, components/script/dom/window.rs, components/script/dom/bluetoothdevice.rs, components/script/dom/document.rs and 17 more
  • @KiChjang: components/script/dom/permissionstatus.rs, components/script/dom/filereader.rs, components/script/dom/window.rs, components/script/dom/bluetoothdevice.rs, components/script/dom/document.rs and 17 more

@highfive
Copy link

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Aug 30, 2017
@emilio
Copy link
Member

emilio commented Aug 30, 2017

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 92b3ef0 has been approved by emilio

@highfive highfive assigned emilio and unassigned wafflespeanut Aug 30, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Aug 30, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 92b3ef0 with merge 7fbd4fb...

bors-servo pushed a commit that referenced this pull request Aug 30, 2017
Auto merge of #18314 - servo:macro-imports, r=emilio
7fbd4fb 
Use absolute paths in the event handlers macros

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18314)
<!-- Reviewable:end -->
@emilio
Copy link
Member

emilio commented Aug 30, 2017

@bors-servo treeclosed+

@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-wpt1

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Aug 30, 2017
@emilio
Copy link
Member

emilio commented Aug 30, 2017

@bors-servo r-

  • Let's wait a second. r=me when all the autoland bustage is fixed

@emilio
Copy link
Member

emilio commented Aug 30, 2017

@bors-servo r+ treeclosed-

@bors-servo
Copy link
Contributor

📌 Commit 92b3ef0 has been approved by emilio

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Aug 30, 2017
@bors-servo
Copy link
Contributor

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only mac-rel-wpt1...

@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-wpt1

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Aug 30, 2017
@jdm
Copy link
Member

jdm commented Aug 30, 2017

@bors-servo: retry

@bors-servo
Copy link
Contributor

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only mac-rel-wpt1...

@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-wpt1

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Aug 30, 2017
@jdm
Copy link
Member

jdm commented Aug 30, 2017

@bors-servo: retry

@nox
Copy link
Contributor Author

nox commented Aug 31, 2017

@bors-servo retry

@bors-servo
Copy link
Contributor

⌛ Testing commit 92b3ef0 with merge 253f199...

bors-servo pushed a commit that referenced this pull request Aug 31, 2017
Auto merge of #18314 - servo:macro-imports, r=emilio
253f199 
Use absolute paths in the event handlers macros

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18314)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Aug 31, 2017
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-wpt

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Aug 31, 2017
@jdm
Copy link
Member

jdm commented Aug 31, 2017

@bors-servo: retry

@bors-servo
Copy link
Contributor

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only linux-rel-wpt, mac-rel-wpt2...

@emilio
Copy link
Member

emilio commented Aug 31, 2017

Homu seems stuck.

@emilio emilio closed this Aug 31, 2017
@emilio emilio reopened this Aug 31, 2017
@emilio
Copy link
Member

emilio commented Aug 31, 2017

@bors-servo r-

  • Please re-push and r+, because homu seems pretty drunk

@emilio emilio closed this Aug 31, 2017
@emilio emilio reopened this Aug 31, 2017
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Sep 1, 2017
@nox
Copy link
Contributor Author

nox commented Sep 1, 2017

@bors-servo r=emilio

@bors-servo
Copy link
Contributor

📌 Commit 7875fea has been approved by emilio

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Sep 1, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 7875fea with merge 15c57e8...

bors-servo pushed a commit that referenced this pull request Sep 1, 2017
Auto merge of #18314 - servo:macro-imports, r=emilio
15c57e8 
Use absolute paths in the event handlers macros

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18314)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing 15c57e8 to master...

@bors-servo bors-servo merged commit 7875fea into master Sep 1, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Sep 1, 2017
@SimonSapin SimonSapin deleted the macro-imports branch September 11, 2017 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@nox @highfive @emilio @bors-servo @jdm @upsuper @wafflespeanut