Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly set default direction of prefixed linear gradients #18321

Merged
merged 1 commit into from Sep 1, 2017
Merged

Properly set default direction of prefixed linear gradients #18321

merged 1 commit into from Sep 1, 2017

Conversation

@canova
Copy link
Member

canova commented Aug 31, 2017 •
edited by Manishearth

The default linear gradient direction is to bottom. This correspondes to
top keyword in prefixed linear gradients. We should preserve the default value.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix Bug 1395189

This change is Reviewable
@canova
Properly set default direction of prefixed linear gradients
Loading status checks…
a0c1eb5 
The default linear gradient direction is `to bottom`. This correspondes to
`top` keyword in prefixed linear gradients. We should preserve the default value.
@highfive
Copy link

highfive commented Aug 31, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/values/specified/image.rs, components/style/values/generics/image.rs, components/style/values/computed/image.rs
  • @emilio: components/style/values/specified/image.rs, components/style/values/generics/image.rs, components/style/values/computed/image.rs
@highfive
Copy link

highfive commented Aug 31, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@canova
Copy link
Member Author

canova commented Aug 31, 2017

r? @Manishearth
You approved this in bugzilla but I had to make some changes in points_downwards method. Can you take a look at this again?
@highfive highfive assigned Manishearth and unassigned nox Aug 31, 2017
@Manishearth
Copy link
Member

Manishearth commented Aug 31, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2017

📌 Commit a0c1eb5 has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2017

⌛ Testing commit a0c1eb5 with merge 97ab0a12b8bbece9f84890897b89dd584274d783...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2017

💔 Test failed - mac-rel-wpt1
@jdm
Copy link
Member

jdm commented Aug 31, 2017

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2017

⌛ Testing commit a0c1eb5 with merge 8de5eea2cd117593feac6554844f679566f29546...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2017

💔 Test failed - mac-dev-unit
@bholley
Copy link
Contributor

bholley commented Aug 31, 2017

You may need to repush.
@jdm
Copy link
Member

jdm commented Aug 31, 2017

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Sep 1, 2017

⌛ Testing commit a0c1eb5 with merge aa119bade06048fe09c3721e870bd4bef7f7d223...
@highfive highfive removed the S-tests-failed label Sep 1, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Sep 1, 2017

💔 Test failed - mac-rel-wpt2
@canova
Copy link
Member Author

canova commented Sep 1, 2017

@bors-servo r=Manishearth

  • why homu, why? :(
@bors-servo
Copy link
Contributor

bors-servo commented Sep 1, 2017

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
  • There's another pull request that is currently being tested, blocking this pull request: #18322
@bors-servo
Copy link
Contributor

bors-servo commented Sep 1, 2017

📌 Commit a0c1eb5 has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Sep 1, 2017

⌛ Testing commit a0c1eb5 with merge ff30f58...
bors-servo added a commit that referenced this pull request Sep 1, 2017
@bors-servo
Auto merge of #18321 - canaltinova:default-linear-gradient, r=Manishe…
Loading status checks…
ff30f58 
…arth

Properly set default direction of prefixed linear gradients

The default linear gradient direction is `to bottom`. This correspondes to
`top` keyword in prefixed linear gradients. We should preserve the default value.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix [Bug 1395189](https://bugzilla.mozilla.org/show_bug.cgi?id=1395189)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18321)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 1, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: Manishearth
Pushing ff30f58 to master...
@bors-servo bors-servo merged commit a0c1eb5 into servo:master Sep 1, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@canova @highfive @Manishearth @bors-servo @jdm @bholley @nox
You can’t perform that action at this time.