Properly set default direction of prefixed linear gradients #18321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default linear gradient direction is `to bottom`. This correspondes to `top` keyword in prefixed linear gradients. We should preserve the default value.
|
Heads up! This PR modifies the following files: |
|
|
highfive
added
the
S-awaiting-review
|
r? @Manishearth |
|
@bors-servo r+ |
|
📌 Commit a0c1eb5 has been approved by |
highfive
added
S-awaiting-merge
|
⌛ Testing commit a0c1eb5 with merge 97ab0a12b8bbece9f84890897b89dd584274d783... |
|
💔 Test failed - mac-rel-wpt1 |
highfive
added
S-tests-failed
|
@bors-servo retry |
|
⌛ Testing commit a0c1eb5 with merge 8de5eea2cd117593feac6554844f679566f29546... |
highfive
added
S-awaiting-merge
|
💔 Test failed - mac-dev-unit |
highfive
added
S-tests-failed
|
You may need to repush. |
|
⌛ Testing commit a0c1eb5 with merge aa119bade06048fe09c3721e870bd4bef7f7d223... |
highfive
added
the
S-awaiting-merge
|
💔 Test failed - mac-rel-wpt2 |
highfive
added
S-tests-failed
|
@bors-servo r=Manishearth
|
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit a0c1eb5 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Sep 1, 2017
…arth Properly set default direction of prefixed linear gradients The default linear gradient direction is `to bottom`. This correspondes to `top` keyword in prefixed linear gradients. We should preserve the default value. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix [Bug 1395189](https://bugzilla.mozilla.org/show_bug.cgi?id=1395189) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18321) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default linear gradient direction is
to bottom. This correspondes totopkeyword in prefixed linear gradients. We should preserve the default value../mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is