Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share specified URLs with Gecko #18516

Merged
merged 1 commit into from Sep 15, 2017
Merged

Share specified URLs with Gecko #18516

merged 1 commit into from Sep 15, 2017

Conversation

jdm
Copy link
Member

@jdm jdm commented Sep 15, 2017 •
edited by SimonSapin

This makes use of our Arc offset machinery to allow Gecko to store Arc values and ensure there are used appropriately.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix bug 1397971.

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko/generated/bindings.rs, components/style/gecko/url.rs, components/style/gecko/generated/structs_debug.rs, ports/geckolib/glue.rs, components/style/gecko/generated/structs_release.rs
  • @canaltinova: components/style/gecko/generated/bindings.rs, components/style/gecko/url.rs, components/style/gecko/generated/structs_debug.rs, components/style/gecko/generated/structs_release.rs
  • @emilio: components/style/gecko/generated/bindings.rs, components/style/gecko/url.rs, components/style/gecko/generated/structs_debug.rs, ports/geckolib/glue.rs, components/style/gecko/generated/structs_release.rs

@highfive
Copy link

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Sep 15, 2017
@jdm
Copy link
Member Author

jdm commented Sep 15, 2017

@bors-servo: r=heycam p=1

@bors-servo
Copy link
Contributor

📌 Commit 329235e has been approved by heycam

@highfive highfive assigned heycam and unassigned glennw Sep 15, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Sep 15, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 329235e with merge d86afc5...

bors-servo pushed a commit that referenced this pull request Sep 15, 2017
Auto merge of #18516 - jdm:stringshare, r=heycam
d86afc5 
Share specified URLs with Gecko

This makes use of our Arc offset machinery to allow Gecko to store Arc<String> values and ensure there are used appropriately.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix [bug 1397971](https://bugzilla.mozilla.org/show_bug.cgi?id=1397971).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18516)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - mac-dev-unit

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Sep 15, 2017
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Sep 15, 2017
@jdm
Copy link
Member Author

jdm commented Sep 15, 2017

@bors-servo: r=heycam

@bors-servo
Copy link
Contributor

📌 Commit d94ad93 has been approved by heycam

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Sep 15, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit d94ad93 with merge 9d914b1...

bors-servo pushed a commit that referenced this pull request Sep 15, 2017
Auto merge of #18516 - jdm:stringshare, r=heycam
9d914b1 
Share specified URLs with Gecko

This makes use of our Arc offset machinery to allow Gecko to store Arc<String> values and ensure there are used appropriately.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix [bug 1397971](https://bugzilla.mozilla.org/show_bug.cgi?id=1397971).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18516)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-dev

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Sep 15, 2017
@highfive highfive removed the S-tests-failed The changes caused existing tests to fail. label Sep 15, 2017
@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Sep 15, 2017
@jdm
Copy link
Member Author

jdm commented Sep 15, 2017

@bors-servo: r=heycam

@bors-servo
Copy link
Contributor

📌 Commit 1a57bad has been approved by heycam

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Sep 15, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 1a57bad with merge 70a6b2f...

bors-servo pushed a commit that referenced this pull request Sep 15, 2017
Auto merge of #18516 - jdm:stringshare, r=heycam
70a6b2f 
Share specified URLs with Gecko

This makes use of our Arc offset machinery to allow Gecko to store Arc<String> values and ensure there are used appropriately.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix [bug 1397971](https://bugzilla.mozilla.org/show_bug.cgi?id=1397971).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18516)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: heycam
Pushing 70a6b2f to master...

@bors-servo bors-servo merged commit 1a57bad into servo:master Sep 15, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Sep 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@heycam heycam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jdm @highfive @bors-servo @heycam @glennw