layout_thread: Avoid adding the UA sheets multiple times when there's no root flow. #18696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @SimonSapin |
|
@bors-servo try |
bors-servo
pushed a commit
that referenced
this pull request
Oct 1, 2017
layout_thread: Avoid adding the UA sheets multiple times when there's no root flow.
|
fixes #18631 |
|
💔 Test failed - mac-rel-wpt4 |
emilio
force-pushed
the
ua-sheets-reflow
branch
from
d061457
to
258e5a5
Compare
… no root flow. Fixes servo#18631
emilio
force-pushed
the
ua-sheets-reflow
branch
from
258e5a5
to
8976b1a
Compare
|
@bors-servo try
|
bors-servo
pushed a commit
that referenced
this pull request
Oct 1, 2017
layout_thread: Avoid adding the UA sheets multiple times when there's no root flow. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18696) <!-- Reviewable:end -->
|
💔 Test failed - linux-rel-wpt |
|
That's an unrelated test. |
|
@bors-servo: r+ |
|
📌 Commit 8976b1a has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Oct 3, 2017
layout_thread: Avoid adding the UA sheets multiple times when there's no root flow. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18696) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is