Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: Iterate in the expected order in the custom_properties module. #18761

Merged
merged 1 commit into from
Oct 5, 2017
Merged

style: Iterate in the expected order in the custom_properties module. #18761

merged 1 commit into from
Oct 5, 2017

Commits on Oct 5, 2017

  1. style: Iterate in the expected order in the custom_properties module. 

    In servo#18745, I replaced a few manual iterations over `index` with the iterator,
and it changed the behavior of `layout/style/test/test_variables_order.html`,
since it turns out that the iterator iterates right to left.

I think this is just an accident that happened due to inconsistencies in how we
were iterating over it, and that our behavior was inconsistent (since we
iterated rtl in some cases, but ltr in others seems like it'd be inconsistent
depending on the depth of the tree and different stuff).

This brings back the expected behavior again, and ensures we iterate over a
consistent order every time.
    @emilio
    emilio committed Oct 5, 2017
    Configuration menu
    Copy the full SHA
    7249733 View commit details
    Browse the repository at this point in the history